From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/dillo: enable jpeg support only with libjpeg provider
Date: Fri, 1 Jan 2016 19:13:26 +0100 [thread overview]
Message-ID: <20160101181326.GA2182@free.fr> (raw)
In-Reply-To: <1451671683-10101-1-git-send-email-romain.naour@gmail.com>
Romain, All,
On 2016-01-01 19:08 +0100, Romain Naour spake thusly:
> dillo add libjpeg to his dependencies when the virtual package
> jpeg is selected. This is wrong because jpeg-turbo can be
> selected instead of libjpeg. So the build of libjpeg can be
> trigged at Makefile level when jpeg-turbo is selected at
> Config.in level by the user.
>
> Since 28f67899e54f15c6e48484ea2976c3e431756bcb, the build
> stop if a package build is trigged at Makefile level without
> being selected at Config.in level.
>
> Use a dependency on the jpeg provider intead of the virtual
> package.
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
> package/dillo/dillo.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/dillo/dillo.mk b/package/dillo/dillo.mk
> index 8eb8d88..45fd611 100644
> --- a/package/dillo/dillo.mk
> +++ b/package/dillo/dillo.mk
> @@ -30,7 +30,7 @@ else
> DILLO_CONF_OPTS += --disable-png
> endif
>
> -ifeq ($(BR2_PACKAGE_JPEG),y)
> +ifeq ($(BR2_PACKAGE_LIBJPEG),y)
> DILLO_CONF_OPTS += --enable-jpeg
> DILLO_DEPENDENCIES += libjpeg
Can dillo be build with jpeg-turbo? If so, it would better to do:
ifeq ($(BR2_PACKAGE_HAS_JPEG),y)
DILLO_CONF_OPTS += --enable-jpeg
DILLO_DEPENDENCIES += jpeg
else
DILLO_CONF_OPTS += --disable-jpeg
endif
Regards,
Yann E. MORIN.
> else
> --
> 2.4.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2016-01-01 18:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-01 18:08 [Buildroot] [PATCH] package/dillo: enable jpeg support only with libjpeg provider Romain Naour
2016-01-01 18:13 ` Yann E. MORIN [this message]
2016-01-01 18:17 ` Romain Naour
2016-01-01 18:48 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160101181326.GA2182@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox