From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libnss: add build workaround for older gcc versions
Date: Wed, 6 Jan 2016 15:54:44 +0100 [thread overview]
Message-ID: <20160106155444.34e63384@free-electrons.com> (raw)
In-Reply-To: <1452089934-10364-1-git-send-email-gustavo@zacarias.com.ar>
Hello,
On Wed, 6 Jan 2016 11:18:54 -0300, Gustavo Zacarias wrote:
> nss uses some #pragma directives that require newish (>= 4.6) versions
> of gcc, so disable Werror when building with older versions to avoid the
> build from breaking unfairly.
> However make this a gcc >= 4.8 conditional since the kludge is called so
> (NSS_NO_GCC48) and other bits might depend upon it.
Here you say the kludge is called NSS_NO_GCC48, but...
> +# #pragma usage needs gcc >= 4.8
> +# See https://bugzilla.mozilla.org/show_bug.cgi?id=1226179
> +ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_4_8),)
> +LIBNSS_BUILD_VARS += NSS_ENABLE_WERROR=0
> +endif
here you use NSS_ENABLE_WERROR.
Is it me misunderstanding your commit message?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-01-06 14:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 14:18 [Buildroot] [PATCH] libnss: add build workaround for older gcc versions Gustavo Zacarias
2016-01-06 14:54 ` Thomas Petazzoni [this message]
2016-01-06 14:56 ` Gustavo Zacarias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106155444.34e63384@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox