From mboxrd@z Thu Jan 1 00:00:00 1970 From: rdkehn at yahoo.com Date: Sun, 10 Jan 2016 10:52:00 -0600 Subject: [Buildroot] [RFC PATCH 1/3] package/dhcp: bump version to 4.3.3 In-Reply-To: <56928073.9010001@mind.be> References: <1452376785-31174-1-git-send-email-rdkehn@yahoo.com> <1452376785-31174-2-git-send-email-rdkehn@yahoo.com> <56928073.9010001@mind.be> Message-ID: <20160110165159.GA2937@dkarchlinux64.gateway.pace.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Arnout, On Sun, Jan 10, 2016 at 05:01:55PM +0100, Arnout Vandecappelle wrote: > On 09-01-16 22:59, Doug Kehn wrote: > [snip] > > +define DHCP_TOOLCHAIN_AR_REF > > + for d in common dhcpctl omapip; do \ > > + sed -i 's#^AR.*#AR = $(TARGET_AR)#' $(@D)/$$d/Makefile; \ > > + done > > +endef > > +DHCP_PRE_BUILD_HOOKS += DHCP_TOOLCHAIN_AR_REF > > This should be a post-patch hook. Or if the Makefile is generated by the > configure step, a post-configure hook (but in that case it would be better to > patch the configure script to generate the right thing to begin with). > > Oh yes, even better is an actual patch that can be upstreamed. I first tried to patch all the relevant Makefile.in where 'AR = ar' is hard coded so the patch could be submitted upstream; however, I could never get the patch to take. Either configure or make would fail. I'll be glad to try any suggestions. Regards, ...doug