From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1 v3] ypbind-mt: new package
Date: Wed, 13 Jan 2016 12:45:27 +0100 [thread overview]
Message-ID: <20160113124527.515f79a0@free-electrons.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1601130838470.11251@tanhuma.tkos.co.il>
Dear Jonathan Ben Avraham,
On Wed, 13 Jan 2016 09:43:10 +0200 (IST), Jonathan Ben Avraham wrote:
> Hi Arnout,
> TP explicitly asked to submit yp-tools and ypbind-mt in separate
> submissions.
No, I said they should be separate *patches*.
You seem to do be aware of the concept of a patch series. See for
example
http://lists.busybox.net/pipermail/buildroot/2016-January/149238.html
and the following e-mails. It is a set of 29 *separate* patches, but
grouped together in a series so that we clearly understand that PATCH 2
needs PATCH 1, that PATCH 3 needs PATCH 2 and so on.
> It is not clear to me how to submit a patch that depends on another
> pending patch having been applied. The possibilities that I see are:
>
> 1. Patch against the current origin and ignore the fact that there is a
> dependency on the yp-tools patch having been applied
>
> 2. Provide the same line added by the patch for yp-tools as part of this
> patch. That is, the ypbind-mt patch would add two lines to
> package/Config.in.
>
> 3. Provide a patch for ypbind-mt that assumes that the patch for yp-tools
> has already been applied to the origin.
>
> What is the correct decision?
Send a patch series. To do so, make N commits in your Git branch. Then
do:
$ git format-patch --cover master
It will generate for you N+1 .patch files, the first one being the
cover letter for the series, the remaining ones being the patches
themselves, one per commit in your branch.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-01-13 11:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 12:45 [Buildroot] [PATCH 1/1 v3] ypbind-mt: new package Jonathan Ben-Avraham
2016-01-12 22:10 ` Arnout Vandecappelle
2016-01-13 6:31 ` Jonathan Ben Avraham
2016-01-13 11:42 ` Thomas Petazzoni
2016-01-13 7:43 ` Jonathan Ben Avraham
2016-01-13 11:45 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113124527.515f79a0@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox