From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date: Fri, 15 Jan 2016 15:00:16 +0100
Subject: [Buildroot] [PATCH] util-linux: enable Python bindings for
 libmount
In-Reply-To: <1452853497-29131-1-git-send-email-yegorslists@googlemail.com>
References: <1452853497-29131-1-git-send-email-yegorslists@googlemail.com>
Message-ID: <20160115150016.0ac51eb3@free-electrons.com>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Yegor,

On Fri, 15 Jan 2016 11:24:57 +0100, yegorslists at googlemail.com wrote:

> diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk
> index 58ace1d..a80e287 100644
> --- a/package/util-linux/util-linux.mk
> +++ b/package/util-linux/util-linux.mk
> @@ -23,8 +23,7 @@ UTIL_LINUX_CONF_ENV = scanf_cv_type_modifier=no \
>  	$(if $(BR2_TOOLCHAIN_USES_UCLIBC),ac_cv_header_sys_timex_h=no)
>  UTIL_LINUX_CONF_OPTS += \
>  	--disable-rpath \
> -	--disable-makeinstall-chown \
> -	--without-python
> +	--disable-makeinstall-chown
>  
>  # system depends on util-linux so we enable systemd support
>  # (which needs systemd to be installed)
> @@ -136,6 +135,19 @@ ifeq ($(BR2_PACKAGE_UTIL_LINUX_BINARIES),)
>  UTIL_LINUX_CONF_OPTS += --disable-all-programs
>  endif
>  
> +# Install libmount Python bindings
> +ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBMOUNT),y)
> +ifeq ($(BR2_PACKAGE_PYTHON)$(BR2_PACKAGE_PYTHON3),y)
> +UTIL_LINUX_CONF_OPTS += \
> +	--enable-pylibmount \
> +	--with-python
> +else
> +UTIL_LINUX_CONF_OPTS += \
> +	--disable-pylibmount \
> +	--without-python
> +endif
> +endif

With this change, we are no longer passing --without-python when
BR2_PACKAGE_UTIL_LINUX_LIBMOUNT is disabled. I think it would be good
to continue passing --without-python. Also, shouldn't python be built
before util-linux for this to work ?

Would something like this make sense maybe:

ifeq ($(BR2_PACKAGE_PYTHON)$(BR2_PACKAGE_PYTHON3),y)
UTIL_LINUX_CONF_OPTS += --with-python
UTIL_LINUX_DEPENDENCIES += $(if $(BR2_PACKAGE_PYTHON),python,python3)
ifeq ($(BR2_PACKAGE_UTIL_LINUX_LIBMOUNT),y)
UTIL_LINUX_CONF_OPTS += --enable-pylibmount
else
UTIL_LINUX_CONF_OPTS += --disable-pylibmount
endif
else
UTIL_LINUX_CONF_OPTS += --without-python
endif

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com