From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sat, 16 Jan 2016 18:25:18 +0100 Subject: [Buildroot] [PATCH] package/canfestival: fix build with musl In-Reply-To: References: <1440279318-19132-1-git-send-email-yann.morin.1998@free.fr> <20150822213815.GA3861@free.fr> <20150822222544.GB3861@free.fr> Message-ID: <20160116182518.44e5f9dc@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Brendan, Yann, On Sat, 22 Aug 2015 23:35:00 +0100, Brendan Heading wrote: > >> I was going to take this up with the developers as I can't see a good > >> reason why the behaviour is different for uclibc and non-uclibc > >> environments, and in any case CLOCK_REALTIME is almost certainly not > >> what they want. But I haven't had a spare moment to write a test case > >> to prove that the timer code used in the non-uclibc version would work > >> just as well under uclibc. > > > > That sounds really weird, indeed... :-( > > It feels like they ran into some kind of issue with uclibc and hacked > together a fix. > > And IME naive coders often make the mistake of using the wrong CLOCK_* > parameters when doing POSIX time related things .. > > > OK, I'll try to revisit this later. Thanks for the heads up. > > I thought about submitting a patch with another #ifdef __UCLIBC__ > around the function declaration - not ideal, but it at least matches > what the upstream were trying to do. But I wasn't sure if such an > approach would pass muster here ? Any progress with this? can-festival still fails to build in the autobuilders due to this: http://autobuild.buildroot.net/results/5c5a48b050223d5f4f66a3a5ddde12cb17e310d7/ Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com