Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] moarvm: disable for sparc64
Date: Sun, 17 Jan 2016 19:25:12 +0200	[thread overview]
Message-ID: <20160117172512.GE10304@tarshish> (raw)
In-Reply-To: <20160117135521.GA11259@waldemar-brodkorb.de>

Hi Waldemar,

On Sun, Jan 17, 2016 at 02:55:21PM +0100, Waldemar Brodkorb wrote:
> Missing implementation of AO_fetch_compare_and_swap in
> libatomic_ops library for sparcv9.
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
> v1 -> v2:
>   * added comment dependency suggested by Baruch Siach
>     it was not possible to use a new dependency line.
> 
> ---
>  package/moarvm/Config.in |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/moarvm/Config.in b/package/moarvm/Config.in
> index 95f3752..038fe6b 100644
> --- a/package/moarvm/Config.in
> +++ b/package/moarvm/Config.in
> @@ -4,6 +4,8 @@ config BR2_PACKAGE_MOARVM
>  	depends on !BR2_STATIC_LIBS # libuv
>  	depends on BR2_USE_MMU # libuv
>  	depends on BR2_PACKAGE_LIBATOMIC_ARCH_SUPPORTS # libatomic_ops
> +	# needs AO_fetch_compare_and_swap, not implemented for sparcv9
> +	depends on !BR2_sparc64
>  	select BR2_PACKAGE_LIBUV
>  	select BR2_PACKAGE_LIBATOMIC_OPS
>  	help
> @@ -12,8 +14,8 @@ config BR2_PACKAGE_MOARVM
>  
>  	  http://moarvm.com
>  
> -comment "moarvm needs a toolchain w/ threads, dynamic library"
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
> +comment "moarvm needs a toolchain w/ threads, dynamic library and complete atomic ops"
> +	depends on BR2_sparc64 || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS

Should be 'depends on !BR2_sparc64' in a separate line. That is, hide the 
comment for sparc64. This is the rule for platform dependencies because the 
user can't just choose a different platform in most cases. For the same reason 
the comment text should not change.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

      reply	other threads:[~2016-01-17 17:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-17 13:55 [Buildroot] [PATCHv2] moarvm: disable for sparc64 Waldemar Brodkorb
2016-01-17 17:25 ` Baruch Siach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160117172512.GE10304@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox