Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/scrub: new package
Date: Mon, 18 Jan 2016 10:23:04 +0100	[thread overview]
Message-ID: <20160118102304.1ccbc389@free-electrons.com> (raw)
In-Reply-To: <1453068293-16263-1-git-send-email-s.martin49@gmail.com>

Samuel,

On Sun, 17 Jan 2016 23:04:53 +0100, Samuel Martin wrote:

> diff --git a/package/scrub/scrub.mk b/package/scrub/scrub.mk
> new file mode 100644
> index 0000000..92837a1
> --- /dev/null
> +++ b/package/scrub/scrub.mk
> @@ -0,0 +1,18 @@
> +################################################################################
> +#
> +# scrub
> +#
> +################################################################################
> +
> +SCRUB_VERSION = 2.6.1
> +SCRUB_SITE = $(call github,chaos,scrub,$(SCRUB_VERSION))
> +SCRUB_LICENSE = GPLv2+
> +SCRUB_LICENSE_FILES = COPYING
> +
> +# tarball of the git repo, but autoreconf does not work as expected, so:

"tarball of the git repo" is unclear, you should rather say: "Fetching
from the git repo, no configure/Makefile generated".

Also, how is it broken?

> +define SCRUB_AUTOCONF_HOOK
> +	( cd $(@D) && PATH=$(BR_PATH) $(@D)/autogen.sh )
> +endef
> +SCRUB_PRE_CONFIGURE_HOOKS += SCRUB_AUTOCONF_HOOK

This is broken if you don't depend on host-automake, host-libtool,
host-autoconf.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-01-18  9:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-17 22:04 [Buildroot] [PATCH] package/scrub: new package Samuel Martin
2016-01-18  9:23 ` Thomas Petazzoni [this message]
2016-01-18 10:37   ` Samuel Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160118102304.1ccbc389@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox