From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 18 Jan 2016 22:56:59 +0100 Subject: [Buildroot] [PATCH 05/80 v1] package/collectd: use 'menuconfig' instead of 'config'+'menu' In-Reply-To: <015a3c362744fb1f25235088a353f3d3689fd62f.1452983019.git.yann.morin.1998@free.fr> References: <015a3c362744fb1f25235088a353f3d3689fd62f.1452983019.git.yann.morin.1998@free.fr> Message-ID: <20160118225659.16e260ac@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Yann E. MORIN, On Sat, 16 Jan 2016 23:36:57 +0100, Yann E. MORIN wrote: > Since there were multiple sub-menus, keep their prompts as a comment, to > properly separate all famillies of plugins. > > Signed-off-by: "Yann E. MORIN" > Acked-by: Arnout Vandecappelle (Essensium/Mind) It is really a matter of taste, so my opinion is clearly not a strong one here. But I believe I actually prefer the current solution. With your solution yes all sub-options are hidden behind a menu. But this menu is now very long, and I find the "comment" in Kconfig to not be very nice separators to separate various parts of the menu. They are even more confusing in that there are "comments" used as separators, and real "comments" about missing dependencies, causing confusion. So I'm not too fan of this one, but if Arnout and you are happy with it and Peter likes it, that's OK, it's really a minor detail from my point of view. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com