From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Tue, 19 Jan 2016 19:29:47 +0100 Subject: [Buildroot] [PATCH v9] toolchain: create symlink ARCH_LIB_DIR->lib in addition to lib32/lib64->lib In-Reply-To: References: <1450787734-2547-1-git-send-email-patrickdepinguin@gmail.com> <20160117154528.1bb05d3e@free-electrons.com> <87lh7l3asr.fsf@dell.be.48ers.dk> Message-ID: <20160119182947.GB3360@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Thomas?, Peter, All, On 2016-01-19 17:01 +0100, Thomas De Schampheleire spake thusly: > On Tue, Jan 19, 2016 at 3:26 PM, Peter Korsgaard wrote: > >>>>>> "Thomas" == Thomas De Schampheleire writes: > > > > Hi, > > > >>> In earlier versions of the patch, I stated that the symlink creation > > >> needs to happen before gcc-initial is built. This is the reason we are > > >> hooking into gcc-initial. This was also effectively the case before > > >> the skeleton package was introduced. > > > > > Small correction, the statement is: > > > +# The creation of lib32/lib64 symlinks into target and staging directories > > > +# needs to be done before the C library is installed. > > > > And that's already the case, right? E.G. all packages depend on > > skeleton, including the glibc/uclibc/musl packages. > > Ok, so that is the missing part of the puzzle. > > On 2015.05, where skeleton was not yet a package, and so the situation > upon which the original patch was based, the symlinks were made in the > .root target. To allow for this new symlink behavior, it had to be > moved, but it had to be before the C library. The toolchain target was > too late, gcc-initial was voted the 'best' place at the time. > > I was not aware that glibc already depends on skeleton. Then indeed > ThomasP's reasoning is correct and the patch should be simplified. I > will investigate that further and resubmit. Skeleton is currently not a dependency of host-gcc-initial, so you'd have to make it so. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'