Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] package/linux-headers: add option to use same sources as the kernel
Date: Wed, 20 Jan 2016 22:03:55 +0100	[thread overview]
Message-ID: <20160120210355.GB3992@free.fr> (raw)
In-Reply-To: <20160120213607.063c1447@free-electrons.com>

Thomas, All,

On 2016-01-20 21:36 +0100, Thomas Petazzoni spake thusly:
> On Wed, 20 Jan 2016 19:34:28 +0100, Yann E. MORIN wrote:
> > +	config BR2_KERNEL_HEADERS_AS_KERNEL
> > +		bool "Same as kernel"
> > +		depends on BR2_LINUX_KERNEL
> > +
> > +	comment "Using the same version as that of the"
> > +		depends on !BR2_LINUX_KERNEL
> > +	comment "kernel needs a kernel to be built.   "
> > +		depends on !BR2_LINUX_KERNEL
> 
> I think this Config.in comment is useless. It is completely obvious
> that if you want to re-use the same kernel headers as the kernel you're
> building, you must have enabled building a kernel with Buildroot.

Yeah, I knew it was redundant; I'll remove it.

> Other than that, the patch looks good. I haven't tested it, but it
> looks good.
> 
> Yet another feature that would desperately need a test case in our test
> suite :-)

Hehe! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2016-01-20 21:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20 18:34 [Buildroot] [PATCH 0/3] toolchain: add possibility to use kernel version for linux-headers (branch yem/kenrel-headers) Yann E. MORIN
2016-01-20 18:34 ` [Buildroot] [PATCH 1/3] package/linux-headers: add option to use same sources as the kernel Yann E. MORIN
2016-01-20 20:36   ` Thomas Petazzoni
2016-01-20 21:03     ` Yann E. MORIN [this message]
2016-02-02  9:05   ` Peter Korsgaard
2016-01-20 18:34 ` [Buildroot] [PATCH 2/3] defconfigs: use the new headers-version-same-as-kernel-version option Yann E. MORIN
2016-01-20 20:38   ` Thomas Petazzoni
2016-01-20 21:29     ` Peter Korsgaard
2016-01-20 21:37       ` Steve Calfee
2016-01-20 22:05         ` Thomas Petazzoni
2016-01-20 22:08         ` Yann E. MORIN
2016-01-20 21:58     ` Yann E. MORIN
2016-01-20 22:07       ` Thomas Petazzoni
2016-01-20 22:15         ` Yann E. MORIN
2016-01-20 18:34 ` [Buildroot] [PATCH 3/3] linux: drop the option to use the same version as that of the headers Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160120210355.GB3992@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox