Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Waldemar Brodkorb <wbx@openadk.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] mpd: disable for sparcv8
Date: Fri, 22 Jan 2016 18:46:52 +0100	[thread overview]
Message-ID: <20160122174652.GM17143@waldemar-brodkorb.de> (raw)
In-Reply-To: <20160120101807.33930860@free-electrons.com>

Hi Thomas,
Thomas Petazzoni wrote,

> Dear Waldemar Brodkorb,
> 
> On Tue, 19 Jan 2016 23:43:38 +0100, Waldemar Brodkorb wrote:
> > Even the main source code in mpd requires some missing
> > atomic ops. So only disable some failing plugins, does not
> > solve the following autobuild error:
> > http://autobuild.buildroot.net/results/e2207280f3a177e12dba502b1c01f5aeb431d04c/
> > 
> > Leon3 works fine.
> > 
> > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> > ---
> >  package/mpd/Config.in |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/package/mpd/Config.in b/package/mpd/Config.in
> > index be0843f..b88c0ca 100644
> > --- a/package/mpd/Config.in
> > +++ b/package/mpd/Config.in
> > @@ -6,6 +6,7 @@ menuconfig BR2_PACKAGE_MPD
> >  	depends on BR2_USE_MMU # libglib2
> >  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_6
> >  	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
> > +	depends on !BR2_sparc_v8 # feature need atomic ops
> 
> To be honest, I don't really like this solution. I know it is the
> easiest quick fix, but it's not the long-term proper solution.
> 
> Instead, I've started looking at all architectures, to see which of the
> __sync_*() and __atomic_*() builtins are supported, when -latomic is
> needed or not needed, etc. Once we have this picture, we can then
> design how such dependencies should be expressed rather than adding
> more and more architecture exclusions.

May be we can add this patch now and when you figured everything out
to do a clean solution, you just use grep to find the problematic
packages disabled for sparc/sparc64.

Therefore we have some fewer autobuild failures meanwhile.
Other atomic related patches got applied, so we should do this until
your refactoring.

best regards
 Waldemar

  reply	other threads:[~2016-01-22 17:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-19 22:43 [Buildroot] [PATCH] mpd: disable for sparcv8 Waldemar Brodkorb
2016-01-20  9:18 ` Thomas Petazzoni
2016-01-22 17:46   ` Waldemar Brodkorb [this message]
2016-01-22 18:06     ` Thomas Petazzoni
2016-02-07 21:04 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160122174652.GM17143@waldemar-brodkorb.de \
    --to=wbx@openadk.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox