From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] vboot-utils: convert to Git formatted patches
Date: Sat, 23 Jan 2016 23:05:15 +0100 [thread overview]
Message-ID: <20160123230515.58f4fe28@free-electrons.com> (raw)
In-Reply-To: <20160123215015.GA27966@vostro>
Hello,
On Sat, 23 Jan 2016 23:50:15 +0200, Alex Suykov wrote:
> > Despite the absence of review/ack, I've applied those two patches since
> > they fix a very frequent build failure (#1 failure in today's report).
>
> Since it was probably me who should have at least tried it:
> the package builds and works well, but there's a typo in the patch.
>
> > -typedef struct rsa_st RSA;
> > +struct rsa_st;
> (...)
> > - RSA* rsa_private_key; /* Private key data */
> > + struct rsa_rt* rsa_private_key; /* Private key data */
>
> The second one should be struct rsa_st, not rsa_rt.
Sigh, how does it build then? Is this structure unused?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-01-23 22:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 21:10 [Buildroot] [PATCH 1/2] vboot-utils: convert to Git formatted patches Thomas Petazzoni
2016-01-21 21:10 ` [Buildroot] [PATCH 2/2] vboot-utils: fix RSA redefinition build error with old compilers Thomas Petazzoni
2016-01-23 12:11 ` [Buildroot] [PATCH 1/2] vboot-utils: convert to Git formatted patches Thomas Petazzoni
2016-01-23 21:50 ` Alex Suykov
2016-01-23 22:05 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160123230515.58f4fe28@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox