From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 2/4] linux-pam: Enable NIS support if yp-tools selected
Date: Sun, 24 Jan 2016 16:51:33 +0100 [thread overview]
Message-ID: <20160124165133.5bdb131d@free-electrons.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1601241734061.4122@tanhuma.tkos.co.il>
Hello,
On Sun, 24 Jan 2016 17:36:26 +0200 (IST), Jonathan Ben Avraham wrote:
> Is this a rule defined in the documentation? I didn't notice it. What is
> the reasoning behind the rule?
Patches are applied in order. If we apply just your PATCH 2/4 without
applying 3/4, then this change will be an orphan change, since
BR2_PACKAGE_YP_TOOLS does not exist.
What you're doing is like adding code calling a function foo() in PATCH
2/4, and then adding the implementation of foo() in PATCH 3/4.
Granted, it's not that bad because if BR2_PACKAGE_YP_TOOLS doesn't
exist, then its value is empty, and your PATCH 2/4 doesn't do anything,
so it doesn't break anything. But it's just some dead code.
Note that these rules are nothing Buildroot specific. If you want to
contribute to any other open-source project like the Linux kernel,
U-Boot or other things, they will ask your patch series to comply with
those exact same rules.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-01-24 15:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-24 14:54 [Buildroot] [PATCH v4 0/4] yp-tools, ypbind-mt: new packages Jonathan Ben-Avraham
2016-01-24 14:55 ` [Buildroot] [PATCH v4 1/4] Add yp-tools and ypbind-mt to packages menu Jonathan Ben-Avraham
2016-01-24 15:09 ` Thomas Petazzoni
2016-01-24 15:33 ` Jonathan Ben Avraham
2016-01-24 15:38 ` Thomas Petazzoni
2016-01-24 15:47 ` Jonathan Ben Avraham
2016-01-24 14:55 ` [Buildroot] [PATCH v4 2/4] linux-pam: Enable NIS support if yp-tools selected Jonathan Ben-Avraham
2016-01-24 15:09 ` Thomas Petazzoni
2016-01-24 15:36 ` Jonathan Ben Avraham
2016-01-24 15:51 ` Thomas Petazzoni [this message]
2016-01-24 14:55 ` [Buildroot] [PATCH v4 3/4] yp-tools: new package Jonathan Ben-Avraham
2016-01-24 14:55 ` [Buildroot] [PATCH v4 4/4] ypbind-mt: " Jonathan Ben-Avraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160124165133.5bdb131d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox