Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] crudini: new package
Date: Tue, 26 Jan 2016 22:56:29 +0100	[thread overview]
Message-ID: <20160126225629.39d6f239@free-electrons.com> (raw)
In-Reply-To: <1453594504-8725-2-git-send-email-mr.zoltan.gyarmati@gmail.com>

Dear Zoltan Gyarmati,

On Sun, 24 Jan 2016 01:15:04 +0100, Zoltan Gyarmati wrote:

> diff --git a/package/crudini/Config.in b/package/crudini/Config.in
> new file mode 100644
> index 0000000..c677f3b
> --- /dev/null
> +++ b/package/crudini/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_CRUDINI
> +	depends on BR2_PACKAGE_PYTHON
> +	select BR2_PACKAGE_PYTHON_INIPARSE
> +	bool "crudini"

See the documentation which has been recently updated on the ordering
of properties:

+As a convention specific to Buildroot, the ordering of the attributes
+is as follows:
+
+1. The type of option: +bool+, +string+... with the prompt
+2. If needed, the +default+ value(s)
+3. Any dependency of the +depends on+ form
+4. Any dependency of the +select+ form
+5. The help keyword and help text.

Also, please indicate above the select BR2_PACKAGE_PYTHON_INIPARSE that
this is a runtime dependency.

> +	help
> +	  A utility for handling ini files from the command line and shell scripts

Wrap at 72 characters.

> diff --git a/package/crudini/crudini.hash b/package/crudini/crudini.hash
> new file mode 100644
> index 0000000..04e2575
> --- /dev/null
> +++ b/package/crudini/crudini.hash
> @@ -0,0 +1,2 @@
> +#md5 from https://pypi.python.org/pypi?:action=show_md5&digest=7d1313f1bb9800db9cbceaa518bcf212
> +md5    7d1313f1bb9800db9cbceaa518bcf212 crudini-0.7.tar.gz

sha256 hash needed.

Other than that, looks good! Can you fix the minor issues above and
resubmit an updated version?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-01-26 21:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-24  0:15 [Buildroot] [PATCH 1/2] python-iniparse: new package Zoltan Gyarmati
2016-01-24  0:15 ` [Buildroot] [PATCH 2/2] crudini: " Zoltan Gyarmati
2016-01-26 21:56   ` Thomas Petazzoni [this message]
2016-01-26 21:53 ` [Buildroot] [PATCH 1/2] python-iniparse: " Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160126225629.39d6f239@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox