Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] rabbitmq-c: link against zlib and libintl
Date: Thu, 28 Jan 2016 09:59:50 +0100	[thread overview]
Message-ID: <20160128095950.6960050d@free-electrons.com> (raw)
In-Reply-To: <1453970725-12387-1-git-send-email-joris.lijssens@gmail.com>

Dear Joris Lijssens,

On Thu, 28 Jan 2016 09:45:25 +0100, Joris Lijssens wrote:
> When building the amqp toolset and static linking is enabled, the
> rabbitmq-c library needs to explicity link against zlib and libintl
> 
> Fixes:
> http://autobuild.buildroot.net/results/2ef/2ef1ed958db8012224f9174334e9c58edace604a/
> Signed-off-by: Joris Lijssens <joris.lijssens@gmail.com>

Hum, I think I already reviewed a similar patch, and said it wasn't
correct, so I still stand on my position that it isn't correct.

If you look at the failure at
http://autobuild.buildroot.net/results/2ef/2ef1ed958db8012224f9174334e9c58edace604a/build-end.log,
rabbitmq-c is *NOT* using zlib or libintl.

What you are seeing is that:

 * libcrypto is using zlib
 * libpopt is using libintl

So rabbitmq-c should *NOT* be changed to link against zlib or libintl.
It should be changed to query OpenSSL (which provides libcrypto) and
popt to know against which libraries to link to use OpenSSL and popt.

See my previous answer on the matter on:

Subject: Re: [Buildroot] [PATCH] rabbitmq-c: link against zlib and libintl
Date: Wed, 20 Jan 2016 10:41:56 +0100

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-01-28  8:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28  8:45 [Buildroot] [PATCH v2] rabbitmq-c: link against zlib and libintl Joris Lijssens
2016-01-28  8:59 ` Thomas Petazzoni [this message]
2016-01-28  9:11   ` Joris Lijssens
2016-01-28 11:06     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160128095950.6960050d@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox