From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/boost: fix build with uClibc-ng
Date: Sun, 31 Jan 2016 08:37:49 +0100 [thread overview]
Message-ID: <20160131083749.534f5dd5@free-electrons.com> (raw)
In-Reply-To: <1454191379-2800-1-git-send-email-bernd.kuhls@t-online.de>
Bernd,
On Sat, 30 Jan 2016 23:02:59 +0100, Bernd Kuhls wrote:
> Fixes
> http://autobuild.buildroot.net/results/fde/fdefe50f4a1ff0888105feedbabab186ab6294cb/
> http://autobuild.buildroot.net/results/f49/f49dc42d81a3abf5515ef68940037e34caee6a1e/
> and others
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/boost/0006-uclibc-no-fenv.patch | 39 +++++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
> create mode 100644 package/boost/0006-uclibc-no-fenv.patch
Thanks a lot for looking into the boost issue. I have some question
below.
> +diff -uNr boost_1_60_0.org/boost/test/execution_monitor.hpp boost_1_60_0/boost/test/execution_monitor.hpp
> +--- boost_1_60_0.org/boost/test/execution_monitor.hpp 2015-12-06 09:50:28.000000000 +0100
> ++++ boost_1_60_0/boost/test/execution_monitor.hpp 2016-01-30 22:55:36.000000000 +0100
> +@@ -484,7 +484,7 @@
> + BOOST_FPE_UNDERFLOW = EM_UNDERFLOW|EM_DENORMAL,
> +
> + BOOST_FPE_ALL = MCW_EM,
> +-#elif defined(BOOST_NO_FENV_H) || defined(BOOST_CLANG)
> ++#elif defined(BOOST_NO_FENV_H) || defined(BOOST_CLANG) || defined(__UCLIBC__)
Boost already checks for the availability of fenv functionality, and
should set BOOST_NO_FENV_H if fenv functionality is not there.
Do you have any idea why the check doesn't work ? We shouldn't have to
add this defined(__UCLIBC__) thing, since Boost should have detected
that uClibc doesn't provide a complete fenv implementation, and define
BOOST_NO_FENV_H.
I've tried to go through the Boost mechanism that does this test, but
it is really not conventional, so I couldn't so far figure out how it
was all working.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-01-31 7:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 22:02 [Buildroot] [PATCH 1/1] package/boost: fix build with uClibc-ng Bernd Kuhls
2016-01-31 7:37 ` Thomas Petazzoni [this message]
2016-02-06 11:56 ` Bernd Kuhls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160131083749.534f5dd5@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox