Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/sredird: fix musl build
Date: Sun, 31 Jan 2016 20:46:48 +0100	[thread overview]
Message-ID: <20160131204648.6a4aa9e6@free-electrons.com> (raw)
In-Reply-To: <1454263304-17588-2-git-send-email-bernd.kuhls@t-online.de>

Bernd,

On Sun, 31 Jan 2016 19:01:44 +0100, Bernd Kuhls wrote:

> diff --git a/package/sredird/0001-termio.patch b/package/sredird/0001-termio.patch
> new file mode 100644
> index 0000000..7c7c67f
> --- /dev/null
> +++ b/package/sredird/0001-termio.patch
> @@ -0,0 +1,20 @@
> +Fix musl build
> +

I've applied, but I still believe that this is a very poor patch
description. Rather than saying it fixes musl, it should explain what
the build failure is, how it is fixed, and that consequently it fixes
musl.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-01-31 19:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-31 18:01 [Buildroot] [PATCH 1/2] package/sredird: bump version to 2.2.2, add hash Bernd Kuhls
2016-01-31 18:01 ` [Buildroot] [PATCH 2/2] package/sredird: fix musl build Bernd Kuhls
2016-01-31 19:46   ` Thomas Petazzoni [this message]
2016-01-31 19:44 ` [Buildroot] [PATCH 1/2] package/sredird: bump version to 2.2.2, add hash Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160131204648.6a4aa9e6@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox