From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] toolchain-external: move the sysroot toolchain support check to helper function
Date: Mon, 1 Feb 2016 15:35:44 +0100 [thread overview]
Message-ID: <20160201153544.581abb55@free-electrons.com> (raw)
In-Reply-To: <1454334017-12326-2-git-send-email-romain.naour@gmail.com>
Romain,
On Mon, 1 Feb 2016 14:40:17 +0100, Romain Naour wrote:
> The sysroot toolchain support check is duplicated at tree location in the
tree location -> three locations
> external toolchain infra. So move it inside the check_unusable_toolchain helper
> that is called when the sysroot is copied to staging directory.
The check_unusable_toolchain helper is called in
TOOLCHAIN_EXTERNAL_CONFIGURE_CMDS, not when the sysroot is copied to
staging.
I think you should state that we can safely remove the checks in
TOOLCHAIN_EXTERNAL_INSTALL_* because the check is already done in
TOOLCHAIN_EXTERNAL_CONFIGURE_CMDS, so we now it is not needed to do it
again later.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-01 14:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 13:40 [Buildroot] [PATCH v2 1/2] toolchain-external: add a check for unsupported toolchains Romain Naour
2016-02-01 13:40 ` [Buildroot] [PATCH v2 2/2] toolchain-external: move the sysroot toolchain support check to helper function Romain Naour
2016-02-01 13:43 ` Romain Naour
2016-02-01 14:35 ` Thomas Petazzoni [this message]
2016-02-01 14:38 ` [Buildroot] [PATCH v2 1/2] toolchain-external: add a check for unsupported toolchains Thomas Petazzoni
2016-02-01 14:57 ` Romain Naour
2016-02-01 15:47 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201153544.581abb55@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox