Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 06/19] python-mistune: new package
Date: Tue, 2 Feb 2016 18:05:10 +0100	[thread overview]
Message-ID: <20160202180510.54ca024b@free-electrons.com> (raw)
In-Reply-To: <1454373899-22481-7-git-send-email-mc5686@mclink.it>

Dear Mauro Condarelli,

On Tue,  2 Feb 2016 01:44:46 +0100, Mauro Condarelli wrote:
> Signed-off-by: Mauro Condarelli <mc5686@mclink.it>
> ---
>  package/Config.in                          |  1 +
>  package/python-mistune/Config.in           |  8 ++++++++
>  package/python-mistune/python-mistune.hash |  3 +++
>  package/python-mistune/python-treq.mk      | 14 ++++++++++++++

This file name is wrong.


> diff --git a/package/python-mistune/Config.in b/package/python-mistune/Config.in
> new file mode 100644
> index 0000000..dd56815
> --- /dev/null
> +++ b/package/python-mistune/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_PYTHON_MISTUNE
> +	bool "python-mistune"
> +	help
> +	  The fastest markdown parser in pure Python 

There's a trailing white space here.

> +	  with renderer features, inspired by marked.

and the wrapping is not good. You should use 72 columns.

> +
> +	  https://pypi.python.org/pypi/mistune
> +

Excessive empty new line here.

> +PYTHON_MISTUNE_VERSION = 0.7.1
> +PYTHON_MISTUNE_SOURCE = mistune-$(PYTHON_MISTUNE_VERSION).tar.gz
> +PYTHON_MISTUNE_SITE = http://pypi.python.org/packages/source/m/mistune
> +PYTHON_MISTUNE_LICENSE = BSD

License is BSD-3c. You should generally never use BSD as the license,
but only BSD-2c, BSD-3c or BSD-4c depending on the variant being used
by the project.

I've applied with those issues fixed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2016-02-02 17:05 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02  0:44 [Buildroot] [PATCH 00/19] Changes needed to compile crossbar Mauro Condarelli
2016-02-02  0:44 ` [Buildroot] [PATCH 01/19] python-jinja2: bump to 2.8 Mauro Condarelli
2016-02-02  5:36   ` Yegor Yefremov
2016-02-02  0:44 ` [Buildroot] [PATCH 02/19] python-characteristic: new package Mauro Condarelli
2016-02-02 13:40   ` Yegor Yefremov
2016-02-02  0:44 ` [Buildroot] [PATCH 03/19] python-cbor: " Mauro Condarelli
2016-02-02 13:48   ` Yegor Yefremov
2016-02-02 16:36   ` Thomas Petazzoni
2016-02-02  0:44 ` [Buildroot] [PATCH 04/19] python-click: " Mauro Condarelli
2016-02-02 13:44   ` Yegor Yefremov
2016-02-02 16:55   ` Thomas Petazzoni
2016-02-02  0:44 ` [Buildroot] [PATCH 05/19] python-lmdb: " Mauro Condarelli
2016-02-02  8:16   ` Yegor Yefremov
2016-02-02 20:26     ` Yegor Yefremov
2016-02-02  0:44 ` [Buildroot] [PATCH 06/19] python-mistune: " Mauro Condarelli
2016-02-02 13:41   ` Yegor Yefremov
2016-02-02 17:05   ` Thomas Petazzoni [this message]
2016-02-02  0:44 ` [Buildroot] [PATCH 07/19] python-netaddr: " Mauro Condarelli
2016-02-02 13:39   ` Yegor Yefremov
2016-02-02 19:38   ` Thomas Petazzoni
2016-02-02  0:44 ` [Buildroot] [PATCH 08/19] python-pycparser: python runtime added Mauro Condarelli
2016-02-02  0:44 ` [Buildroot] [PATCH 09/19] python-pygments: new package Mauro Condarelli
2016-02-02  9:26   ` Yegor Yefremov
2016-02-02  0:44 ` [Buildroot] [PATCH 10/19] python-pynacl: " Mauro Condarelli
2016-02-02  8:11   ` Yegor Yefremov
2016-02-02  0:44 ` [Buildroot] [PATCH 11/19] python-pytrie: " Mauro Condarelli
2016-02-02 13:37   ` Yegor Yefremov
2016-02-02  0:44 ` [Buildroot] [PATCH 12/19] python-service-identity: " Mauro Condarelli
2016-02-02 13:47   ` Yegor Yefremov
2016-02-02  0:44 ` [Buildroot] [PATCH 13/19] python-shutilwhich: " Mauro Condarelli
2016-02-02 13:46   ` Yegor Yefremov
2016-02-02  0:44 ` [Buildroot] [PATCH 14/19] python-treq: " Mauro Condarelli
2016-02-02  9:11   ` Yegor Yefremov
2016-02-02  0:44 ` [Buildroot] [PATCH 15/19] python-txaio: " Mauro Condarelli
2016-02-02 13:34   ` Yegor Yefremov
2016-02-02  0:44 ` [Buildroot] [PATCH 16/19] python-msgpack: bump to 0.4.7 Mauro Condarelli
2016-02-02  7:31   ` Yegor Yefremov
2016-02-02  0:44 ` [Buildroot] [PATCH 17/19] python-pyasn-modules: new package Mauro Condarelli
2016-02-02  8:36   ` Yegor Yefremov
2016-02-02  0:44 ` [Buildroot] [PATCH 18/19] python-autobahn: " Mauro Condarelli
2016-02-02 13:48   ` Yegor Yefremov
2016-02-02  0:44 ` [Buildroot] [PATCH 19/19] python-crossbar: " Mauro Condarelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160202180510.54ca024b@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox