Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] yad: fix libgtk3 dependency
Date: Sun, 7 Feb 2016 23:32:41 +0100	[thread overview]
Message-ID: <20160207233241.7e5eb5b9@free-electrons.com> (raw)
In-Reply-To: <1454504515-4365-1-git-send-email-gustavo@zacarias.com.ar>

Dear Gustavo Zacarias,

On Wed,  3 Feb 2016 10:01:55 -0300, Gustavo Zacarias wrote:
> Make it depend explicitly on BR2_PACKAGE_LIBGTK3_X11 (the X11 backend
> option) to avoid the checker from complaining.
> Also add a comment about yad requiring the X11 backend otherwise it's
> ambiguous if a user has libgtk3 enabled with broadway/wayland and the
> comment shows up. Fixes:
> http://autobuild.buildroot.net/results/84d/84d97bbcc0ea4f8eaa50dd25bf9ee8fdee4b937f/
> 
> Also cleanup some tiny whitespace in the package mk file.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

Applied, but see one question below.

> ---
>  package/yad/Config.in | 6 +++---
>  package/yad/yad.mk    | 1 -
>  2 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/package/yad/Config.in b/package/yad/Config.in
> index e4b63a2..50b97c5 100644
> --- a/package/yad/Config.in
> +++ b/package/yad/Config.in
> @@ -1,13 +1,13 @@
>  config BR2_PACKAGE_YAD
>  	bool "yad"
>  	depends on BR2_PACKAGE_XORG7
> -	depends on BR2_PACKAGE_LIBGTK2 || BR2_PACKAGE_LIBGTK3
> +	depends on BR2_PACKAGE_LIBGTK2 || BR2_PACKAGE_LIBGTK3_X11

Is the BR2_PACKAGE_XORG7 dependency still needed, then?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-02-07 22:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 13:01 [Buildroot] [PATCH] yad: fix libgtk3 dependency Gustavo Zacarias
2016-02-07 22:32 ` Thomas Petazzoni [this message]
2016-02-08  0:22   ` Gustavo Zacarias
2016-02-08  8:17     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160207233241.7e5eb5b9@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox