From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 8 Feb 2016 17:25:09 +0100 Subject: [Buildroot] [PATCH 1/1] skeleton: Rename /etc/profile.d/umask to umask.sh In-Reply-To: <1454946165-8192-1-git-send-email-nicolas.cavallari@green-communications.fr> References: <1454946165-8192-1-git-send-email-nicolas.cavallari@green-communications.fr> Message-ID: <20160208172509.2e68a8ba@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Nicolas, Thanks for noticing this bug! On Mon, 8 Feb 2016 16:42:45 +0100, Nicolas Cavallari wrote: > /etc/profile only sources files that matches the /etc/profile.d/*.sh > pattern, so /etc/profile.d/umask was never sourced. > > Signed-off-by: Nicolas Cavallari > --- > system/skeleton/etc/profile.d/{umask => umask.sh} | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename system/skeleton/etc/profile.d/{umask => umask.sh} (100%) > > diff --git a/system/skeleton/etc/profile.d/umask b/system/skeleton/etc/profile.d/umask.sh > similarity index 100% > rename from system/skeleton/etc/profile.d/umask > rename to system/skeleton/etc/profile.d/umask.sh I'd rather think that /etc/profile should source all files in /etc/profile.d/. At least that's what I would expect from a .d/ directory. What do others think about this? Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com