Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Fwd: [PATCH 1/1] uboot: Strip "-Wl," from LDFLAGS
Date: Wed, 10 Feb 2016 17:41:15 +0100	[thread overview]
Message-ID: <20160210174115.5c7f174d@free-electrons.com> (raw)
In-Reply-To: <CANCHnQppW3mmP=6WGBChD06+7ns0u1D5R6MQb=pxCmV6nQ7=Mw@mail.gmail.com>

Hello,

Thanks for this patch! See some comments below.

On Wed, 10 Feb 2016 16:03:23 +0100, Jeroen Roovers wrote:
> ---------- Forwarded message ----------
> From: Jeroen Roovers <jer@airfi.aero>
> Date: 10 February 2016 at 12:15
> Subject: [PATCH 1/1] uboot: Strip "-Wl," from LDFLAGS
> To: buildroot at buildroot.org
> Cc: Jeroen Roovers <jer@airfi.aero>
> 
> 
>     If we want to set proper LDFLAGS, then we need to mangle that in the
>     uboot build system as it calls ld(1) (in fact ld.bfd) directly,
>     where the "-Wl," prefix should only be used when the linker is
>     called indirectly through gcc(1).
> 
> Signed-off-by: Jeroen Roovers <jer@airfi.aero>

What specific/real problem is this fixing? I.e in which
situation/configuration are you seeing that TARGET_LDFLAGS contains a
-Wl option?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-02-10 16:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1455102927-28502-1-git-send-email-jer@airfi.aero>
2016-02-10 15:03 ` [Buildroot] Fwd: [PATCH 1/1] uboot: Strip "-Wl," from LDFLAGS Jeroen Roovers
2016-02-10 16:41   ` Thomas Petazzoni [this message]
     [not found]     ` <CANCHnQogKCY-OTT2=wTkNJ8D52QWetBqdnWbfAqRKKcoW8Yrpw@mail.gmail.com>
     [not found]       ` <CANCHnQp5E4kx=2VpVDXAC-sn+ruxe=0nwamG=DXp_WEgQVCRjw@mail.gmail.com>
2016-02-19 15:04         ` [Buildroot] Fwd: Fwd: [PATCH 1/1] uboot: Strip "-Wl, " " Jeroen Roovers
2016-06-03 13:18   ` [Buildroot] Fwd: [PATCH 1/1] uboot: Strip "-Wl," " Thomas Petazzoni
2016-06-03 14:00     ` Jeroen Roovers
2016-06-03 14:03       ` Thomas Petazzoni
2016-06-03 14:10         ` Jeroen Roovers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160210174115.5c7f174d@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox