From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/numactl: Fix uClibc compile breakage after musl compile fix
Date: Sat, 13 Feb 2016 18:15:53 +0100 [thread overview]
Message-ID: <20160213181553.2e05bb6d@free-electrons.com> (raw)
In-Reply-To: <20160213173119.0aa5f7c9@free-electrons.com>
Hello,
On Sat, 13 Feb 2016 17:31:19 +0100, Thomas Petazzoni wrote:
> Then I don't really understand. The original problem was:
>
> syscall.c:118:41: error: missing binary operator before token "("
> #if defined(__GLIBC__) && __GLIBC_PREREQ(2, 11)
>
> But musl doesn't defined __GLIBC__. So I don't see how it would be
> different to do:
>
> #if defined(__GLIBC__) && __GLIBC_PREREQ(2, 11)
>
> or
>
> #if defined(__GLIBC_PREREQ) && __GLIBC_PREREQ(2, 11)
>
> When neither __GLIBC__ nor __GLIBC_PREREQ are defined (which is the
> case with musl).
And indeed, with your new patch applied, the build still fails with
musl:
syscall.c:118:46: error: missing binary operator before token "("
#if defined(__GLIBC_PREREQ) && __GLIBC_PREREQ(2, 11)
This really needs to be within a #if defined(__GLIBC__).
Can you submit a patch that fixes this, and test it with glibc, uclibc
and musl?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-02-13 17:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 19:22 [Buildroot] [PATCH v2 1/1] package/numactl: Fix uClibc compile breakage after musl compile fix Bernd Kuhls
2016-02-12 21:49 ` Thomas Petazzoni
2016-02-13 15:33 ` Bernd Kuhls
2016-02-13 16:31 ` Thomas Petazzoni
2016-02-13 17:15 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160213181553.2e05bb6d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox