From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next 4/4] package/mjpg-streamer: added optional dependency to libv4l
Date: Sun, 14 Feb 2016 21:56:49 +0100 [thread overview]
Message-ID: <20160214215649.07a73997@free-electrons.com> (raw)
In-Reply-To: <1455442176-31448-4-git-send-email-bernd.kuhls@t-online.de>
Dear Bernd Kuhls,
On Sun, 14 Feb 2016 10:29:36 +0100, Bernd Kuhls wrote:
> +ifeq ($(BR2_PACKAGE_LIBV4L),y)
> +MJPG_STREAMER_DEPENDENCIES += libv4l
> +MJPG_STREAMER_USE_LIBV4L += USE_LIBV4L2=true
> +endif
On this one, some possible further improvements:
- Use a variable named MJPG_STREAMER_MAKE_OPTS and not
MJPG_STREAMER_USE_LIBV4L.
- Pass USE_LIBV4L2=false when libv4l is not enabled (if passing =false
actually has the intended effect)
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-14 20:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-14 9:29 [Buildroot] [PATCH/next 1/4] package/libass: bump version to 0.13.1 Bernd Kuhls
2016-02-14 9:29 ` [Buildroot] [PATCH/next 2/4] package/libnfs: bump version to 1.10.0 Bernd Kuhls
2016-02-14 9:29 ` [Buildroot] [PATCH/next 3/4] package/libv4l: " Bernd Kuhls
2016-02-14 9:29 ` [Buildroot] [PATCH/next 4/4] package/mjpg-streamer: added optional dependency to libv4l Bernd Kuhls
2016-02-14 20:56 ` Thomas Petazzoni [this message]
2016-02-14 20:55 ` [Buildroot] [PATCH/next 1/4] package/libass: bump version to 0.13.1 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160214215649.07a73997@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox