From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] e2fsprogs: remove findfs option
Date: Sun, 14 Feb 2016 22:06:51 +0100 [thread overview]
Message-ID: <20160214220651.2cf79206@free-electrons.com> (raw)
In-Reply-To: <1455295206-15684-1-git-send-email-james.knight@rockwellcollins.com>
Dear James Knight,
On Fri, 12 Feb 2016 11:40:05 -0500, James Knight wrote:
> The e2fsprogs package's findfs option provides no capabilities. When the
> option is selected, a symbolic link is generated from findfs to e2label;
> however, e2label will not handle findfs since the respective code is
> explicitly disabled when `--disable-libblkid` is passed in. At this
> time, the e2fsprogs package only supports findfs capabilities when
> building its "private blkid library".
>
> Note that the `--disable-libblkid` configuration argument must remain
> to prevent conflicts with util-linux's libblkid and an e2fsprogs-
> generated variant (see e1ffc2f791b336339909c90559b7db40b455f172).
>
> Since e2fsprogs cannot provide findfs capabilities, the option is being
> removed in this change. A following change will be introduced to include
> util-linux's findfs utility.
>
> Signed-off-by: James Knight <james.knight@rockwellcollins.com>
> Cc: Zheng Yi <yzheng@techyauld.com>
> ---
> Changes v1 -> v2:
> - Add missing legacy handling (pointed out by Thomas Petazzoni).
> ---
> Config.in.legacy | 9 +++++++++
> package/e2fsprogs/Config.in | 5 -----
> package/e2fsprogs/e2fsprogs.mk | 9 ---------
> 3 files changed, 9 insertions(+), 14 deletions(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-02-14 21:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 16:40 [Buildroot] [PATCH v2 1/2] e2fsprogs: remove findfs option James Knight
2016-02-12 16:40 ` [Buildroot] [PATCH v2 2/2] util-linux: add " James Knight
2016-02-14 21:07 ` Thomas Petazzoni
2016-02-14 21:06 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160214220651.2cf79206@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox