Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] qt5tools: new package
Date: Sat, 20 Feb 2016 23:06:57 +0100	[thread overview]
Message-ID: <20160220230657.46a13638@gmx.net> (raw)
In-Reply-To: <20160219143219.GA30826@kwain>

Hello Antoine Tenart,

On Fri, 19 Feb 2016 15:32:20 +0100, Antoine Tenart <antoine.tenart@free-electrons.com> wrote:

> Hello Peter,
> 
> I tested your patch to build the QT5 Linguistic Tools, and it worked
> well :)
> 

Thanks for testing...

> However I have one comment:
> 
> On Fri, Feb 05, 2016 at 03:30:15PM +0100, Peter Seiderer wrote:
> > +
> > +define QT5TOOLS_INSTALL_STAGING_CMDS
> 
> I think you need to call the 'install' target here, to install the QT5
> Tools cmake modules in the host directory:
> 
> 	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install
> 

Thanks for the hint, will send an updated patch soon, mind to give the cmake
part a little test?

Regards,
Peter

> > +	$(foreach p,$(QT5TOOLS_INSTALL_STAGING_y), \
> > +		$(INSTALL) -D -m0755 $(@D)/bin/$(p) $(HOST_DIR)/usr/bin/$(p)$(sep))
> > +endef
> 
> Thanks,
> 
> Antoine
> 

      reply	other threads:[~2016-02-20 22:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-05 14:30 [Buildroot] [PATCH v4] qt5tools: new package Peter Seiderer
2016-02-19 14:32 ` Antoine Tenart
2016-02-20 22:06   ` Peter Seiderer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160220230657.46a13638@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox