Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 10/18] erlang-p1_stun: bump to version 0.9.0
Date: Sat, 20 Feb 2016 23:30:43 +0100	[thread overview]
Message-ID: <20160220233043.2be4fa0c@free-electrons.com> (raw)
In-Reply-To: <1454443064-14269-11-git-send-email-fhunleth@troodon-software.com>

Dear Frank Hunleth,

On Tue,  2 Feb 2016 14:57:36 -0500, Frank Hunleth wrote:
> As part of the version change, the package name changed to use an
> underscore rather than a hyphen. Fortunately, the name change doesn't
> affect the Config.in option, so no legacy handling is needed.
> 
> Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com>

As suggested by Romain in his review, I've dropped the rename.
Generally speaking, when things aren't clear between _ and -, I very
much prefer to see - used in package name (though I admit this is a
personal preference).


>  config BR2_PACKAGE_ERLANG_P1_STUN
> -	bool "erlang-p1-stun"
> -	select BR2_PACKAGE_ERLANG_P1_TLS
> +	bool "erlang-p1_stun"
> +	select BR2_PACKAGE_ERLANG_FAST_TLS

Build testing has shown that BR2_PACKAGE_ERLANG_FAST_TLS was not the
proper dependency, and instead keeping BR2_PACKAGE_ERLANG_P1_TLS was
the right solution. Could you double check why you switched to
fast_tls ?

So, I've applied to next, with the following changes:

    [Thomas:
     - do only the version bump, not the package rename, as suggested by
       Romain Naour
     - erlang-p1-stun continues to depend on erlang-p1-tls, not
       erlang-fast_tls.]

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2016-02-20 22:30 UTC|newest]

Thread overview: 95+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-23  1:10 [Buildroot] [PATCH 00/18] Erlang 18 and native atomic ops Frank Hunleth
2016-01-23  1:10 ` [Buildroot] [PATCH 01/18] erlang: bump to version 18.2.1 Frank Hunleth
2016-02-01 20:47   ` Romain Naour
2016-01-23  1:10 ` [Buildroot] [PATCH 02/18] pkg-rebar.mk: pass C++ compiler path and options Frank Hunleth
2016-01-23  1:10 ` [Buildroot] [PATCH 03/18] erlang-goldrush: bump to version 0.1.8 Frank Hunleth
2016-01-23  1:10 ` [Buildroot] [PATCH 04/18] erlang-lager: bump to version 2.2.0 Frank Hunleth
2016-01-23  1:10 ` [Buildroot] [PATCH 05/18] erlang-rebar: bump to version 2.6.1 Frank Hunleth
2016-01-23  1:10 ` [Buildroot] [PATCH 06/18] erlang-fast_tls: new package Frank Hunleth
2016-01-23  8:20   ` Thomas Petazzoni
2016-02-01 20:38     ` Romain Naour
2016-01-23  1:11 ` [Buildroot] [PATCH 07/18] erlang-p1-cache-tab: bump to version 1.0.1 Frank Hunleth
2016-01-23  1:11 ` [Buildroot] [PATCH 08/18] erlang-p1-iconv: bump to version 0.9.0 Frank Hunleth
2016-01-23  1:11 ` [Buildroot] [PATCH 09/18] erlang-p1-stringprep: bump to version 1.0.0 Frank Hunleth
2016-01-23  1:11 ` [Buildroot] [PATCH 10/18] erlang-p1_stun: bump to version 0.9.0 Frank Hunleth
2016-01-23  8:21   ` Thomas Petazzoni
2016-01-23  1:11 ` [Buildroot] [PATCH 11/18] erlang-p1-sip: bump to version 1.0.0 Frank Hunleth
2016-01-23  1:11 ` [Buildroot] [PATCH 12/18] erlang-p1-tls: " Frank Hunleth
2016-01-23  1:11 ` [Buildroot] [PATCH 13/18] erlang-p1-utils: bump to version 1.0.3 Frank Hunleth
2016-02-01 21:04   ` Romain Naour
2016-01-23  1:11 ` [Buildroot] [PATCH 14/18] erlang-p1-xml: bump to version 1.1.1 Frank Hunleth
2016-01-23  1:11 ` [Buildroot] [PATCH 15/18] erlang-p1-yaml: bump to version 1.0.0 Frank Hunleth
2016-01-23  1:11 ` [Buildroot] [PATCH 16/18] erlang-p1-zlib: " Frank Hunleth
2016-01-23  1:11 ` [Buildroot] [PATCH 17/18] ejabberd: bump to version 16.01 Frank Hunleth
2016-01-23  1:11 ` [Buildroot] [PATCH 18/18] erlang: make libatomic_ops optional Frank Hunleth
2016-01-23  8:25   ` Thomas Petazzoni
2016-01-26  0:43     ` Frank Hunleth
2016-02-01 21:55       ` Thomas Petazzoni
2016-02-02 19:57   ` [Buildroot] [PATCH v2 00/18] Erlang 18 and native atomic ops Frank Hunleth
2016-02-02 19:57     ` [Buildroot] [PATCH v2 01/18] erlang: bump to version 18.2.1 Frank Hunleth
2016-02-06 22:28       ` Romain Naour
2016-02-20 18:22       ` Thomas Petazzoni
2016-02-02 19:57     ` [Buildroot] [PATCH v2 02/18] pkg-rebar.mk: pass C++ compiler path and options Frank Hunleth
2016-02-06 22:34       ` Romain Naour
2016-02-09  1:45         ` Frank Hunleth
2016-02-20 18:23       ` Thomas Petazzoni
2016-02-02 19:57     ` [Buildroot] [PATCH v2 03/18] erlang-goldrush: bump to version 0.1.8 Frank Hunleth
2016-02-06 22:35       ` Romain Naour
2016-02-20 18:23       ` Thomas Petazzoni
2016-02-02 19:57     ` [Buildroot] [PATCH v2 04/18] erlang-lager: bump to version 2.2.0 Frank Hunleth
2016-02-06 22:36       ` Romain Naour
2016-02-20 18:24       ` Thomas Petazzoni
2016-02-02 19:57     ` [Buildroot] [PATCH v2 05/18] erlang-rebar: bump to version 2.6.1 Frank Hunleth
2016-02-06 22:39       ` Romain Naour
2016-02-09  1:58         ` Frank Hunleth
2016-02-20 17:37         ` Thomas Petazzoni
2016-02-20 18:08           ` Yann E. MORIN
2016-02-20 23:05             ` Arnout Vandecappelle
2016-02-20 23:19               ` Yann E. MORIN
2016-02-21  0:02                 ` Arnout Vandecappelle
2016-02-21  8:37                   ` Peter Korsgaard
2016-02-20 18:24       ` Thomas Petazzoni
2016-02-20 18:31         ` Frank Hunleth
2016-02-20 22:54           ` Thomas Petazzoni
2016-02-02 19:57     ` [Buildroot] [PATCH v2 06/18] erlang-fast_tls: new package Frank Hunleth
2016-02-06 22:42       ` Romain Naour
2016-02-20 18:25       ` Thomas Petazzoni
2016-02-02 19:57     ` [Buildroot] [PATCH v2 07/18] erlang-p1-cache-tab: bump to version 1.0.1 Frank Hunleth
2016-02-06 22:43       ` Romain Naour
2016-02-20 18:26       ` Thomas Petazzoni
2016-02-02 19:57     ` [Buildroot] [PATCH v2 08/18] erlang-p1-iconv: bump to version 0.9.0 Frank Hunleth
2016-02-06 22:45       ` Romain Naour
2016-02-20 18:26       ` Thomas Petazzoni
2016-02-02 19:57     ` [Buildroot] [PATCH v2 09/18] erlang-p1-stringprep: bump to version 1.0.0 Frank Hunleth
2016-02-06 22:47       ` Romain Naour
2016-02-20 22:28       ` Thomas Petazzoni
2016-02-02 19:57     ` [Buildroot] [PATCH v2 10/18] erlang-p1_stun: bump to version 0.9.0 Frank Hunleth
2016-02-06 22:52       ` Romain Naour
2016-02-09  2:23         ` Frank Hunleth
2016-02-20 22:30       ` Thomas Petazzoni [this message]
2016-02-20 23:09         ` Frank Hunleth
2016-02-20 23:12           ` Thomas Petazzoni
2016-02-21 22:16             ` Frank Hunleth
2016-02-02 19:57     ` [Buildroot] [PATCH v2 11/18] erlang-p1-sip: bump to version 1.0.0 Frank Hunleth
2016-02-06 22:58       ` Romain Naour
2016-02-20 22:31       ` Thomas Petazzoni
2016-02-02 19:57     ` [Buildroot] [PATCH v2 12/18] erlang-p1-tls: " Frank Hunleth
2016-02-06 23:01       ` Romain Naour
2016-02-20 22:31       ` Thomas Petazzoni
2016-02-02 19:57     ` [Buildroot] [PATCH v2 13/18] erlang-p1-utils: bump to version 1.0.3 Frank Hunleth
2016-02-06 23:02       ` Romain Naour
2016-02-20 22:34       ` Thomas Petazzoni
2016-02-02 19:57     ` [Buildroot] [PATCH v2 14/18] erlang-p1-xml: bump to version 1.1.1 Frank Hunleth
2016-02-06 23:07       ` Romain Naour
2016-02-20 22:35       ` Thomas Petazzoni
2016-02-02 19:57     ` [Buildroot] [PATCH v2 15/18] erlang-p1-yaml: bump to version 1.0.0 Frank Hunleth
2016-02-06 23:10       ` Romain Naour
2016-02-20 22:35       ` Thomas Petazzoni
2016-02-02 19:57     ` [Buildroot] [PATCH v2 16/18] erlang-p1-zlib: " Frank Hunleth
2016-02-06 23:13       ` Romain Naour
2016-02-20 22:52       ` Thomas Petazzoni
2016-02-02 19:57     ` [Buildroot] [PATCH v2 17/18] ejabberd: bump to version 16.01 Frank Hunleth
2016-02-06 23:24       ` Romain Naour
2016-02-02 19:57     ` [Buildroot] [PATCH v2 18/18] erlang: support choosing atomic ops Frank Hunleth
2016-02-07 12:49       ` Romain Naour
2016-02-07 13:15         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160220233043.2be4fa0c@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox