Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 12/14] package/pulseaudio: add optional support for udev
Date: Sun, 21 Feb 2016 12:48:43 +0100	[thread overview]
Message-ID: <20160221124843.444de9e1@free-electrons.com> (raw)
In-Reply-To: <1456048218-4061-12-git-send-email-bernd.kuhls@t-online.de>

Bernd,

On Sun, 21 Feb 2016 10:50:16 +0100, Bernd Kuhls wrote:
> When udev was compiled before, pulseaudio will use it as optional
> dependency:
> 
> $ output/host/usr/bin/x86_64-linux-readelf -a output/target/usr/lib/pulse-8.0/modules/module-alsa-sink.so | grep NEEDED
> [...]
>  0x0000000000000001 (NEEDED)             Shared library: [libudev.so.1]
> [...]
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/pulseaudio/pulseaudio.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/pulseaudio/pulseaudio.mk b/package/pulseaudio/pulseaudio.mk
> index 36661cc..fbac516 100644
> --- a/package/pulseaudio/pulseaudio.mk
> +++ b/package/pulseaudio/pulseaudio.mk
> @@ -79,6 +79,13 @@ else
>  PULSEAUDIO_CONF_OPTS += --without-soxr
>  endif
>  
> +ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
> +PULSEAUDIO_CONF_OPTS += --enable-libudev
> +PULSEAUDIO_DEPENDENCIES += udev
> +else
> +PULSEAUDIO_CONF_OPTS += --disable-libudev
> +endif

The udev dependency was already handled by:

	$(if $(BR2_PACKAGE_HAS_UDEV),udev)

However, your patch makes it more explicit by using --enable/--disable.
I've therefore adapted your patch and its commit log before applying.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-02-21 11:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-21  9:50 [Buildroot] [PATCH 01/14] package/patch: add optional support for attr Bernd Kuhls
2016-02-21  9:50 ` [Buildroot] [PATCH 02/14] package/libglib2: add optional support for elfutils Bernd Kuhls
2016-02-21  9:50 ` [Buildroot] [PATCH 03/14] package/pure-ftpd: " Bernd Kuhls
2016-02-21  9:50 ` [Buildroot] [PATCH 04/14] package/iproute2: " Bernd Kuhls
2016-02-21  9:50 ` [Buildroot] [PATCH 05/14] package/openipmi: add optional support for gdbm Bernd Kuhls
2016-02-21  9:50 ` [Buildroot] [PATCH 06/14] package/zsh: " Bernd Kuhls
2016-02-21  9:50 ` [Buildroot] [PATCH 07/14] package/zsh: add optional support for libcap Bernd Kuhls
2016-02-21  9:50 ` [Buildroot] [PATCH 08/14] package/zsh: add optional support for pcre Bernd Kuhls
2016-02-21  9:50 ` [Buildroot] [PATCH 09/14] package/pulseaudio: add optional support for gdbm Bernd Kuhls
2016-02-21  9:50 ` [Buildroot] [PATCH 10/14] package/pulseaudio: add optional support for jack2 Bernd Kuhls
2016-02-21  9:50 ` [Buildroot] [PATCH 11/14] package/pulseaudio: add optional support for libsoxr Bernd Kuhls
2016-02-21  9:50 ` [Buildroot] [PATCH 12/14] package/pulseaudio: add optional support for udev Bernd Kuhls
2016-02-21 11:48   ` Thomas Petazzoni [this message]
2016-02-21  9:50 ` [Buildroot] [PATCH 13/14] package/jack2: add optional support for opus Bernd Kuhls
2016-02-21 10:51   ` Arnout Vandecappelle
2016-02-21 11:03     ` Bernd Kuhls
2016-02-21 12:43       ` Yann E. MORIN
2016-02-21  9:50 ` [Buildroot] [PATCH 14/14] package/jack2: add optional support for readline Bernd Kuhls
2016-02-21 11:47 ` [Buildroot] [PATCH 01/14] package/patch: add optional support for attr Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160221124843.444de9e1@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox