Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] Update libaio to 0.3.110
Date: Sun, 21 Feb 2016 15:37:09 +0100	[thread overview]
Message-ID: <20160221153709.1bfa1230@free-electrons.com> (raw)
In-Reply-To: <1455824391-23524-1-git-send-email-alistair.francis@xilinx.com>

Alistair,

Thanks for the patch!

On Thu, 18 Feb 2016 11:39:51 -0800, Alistair Francis wrote:
> Update libaio from 0.3.108 to 0.3.110. This adds AArch64 support.
> 
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
>  package/libaio/0001-arches.patch | 454 ++-------------------------------------
>  package/libaio/Config.in         |   2 +-
>  package/libaio/libaio.hash       |   4 +-
>  package/libaio/libaio.mk         |   2 +-
>  4 files changed, 20 insertions(+), 442 deletions(-)

It took me a bit of time to understand why we can reduce the patch to
just MIPS definitions. Indeed, in the patch, there are some m68k and
PA-RISC definitions which we don't really care about since we don't
support those architectures. However, the SPARC definitions we do care
about. But in fact, they have been merged upstream. It would have been
good to add such explanations in the commit log, to ease review. I've
adjusted the commit log to make this explicit.

Another comment is that the title should always be:

	<package>: <what happens>

i.e something like:

	libaio: bump to version 0.3.110


> +The patch adds MIPS specific definitions (syscall number and macros).

Vicente, can you work with libaio upstream to get the MIPS specific
definitions merged? Maybe this should also be enabled on
mips64/mips64el.

> diff --git a/package/libaio/Config.in b/package/libaio/Config.in
> index cc44cb6..63db829 100644
> --- a/package/libaio/Config.in
> +++ b/package/libaio/Config.in
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS
>  	bool
>  	default y if BR2_arm || BR2_armeb || BR2_i386 || \
>  		BR2_m68k || BR2_mips || BR2_mipsel || BR2_powerpc || \
> -		BR2_sparc || BR2_x86_64
> +		BR2_sparc || BR2_x86_64 || BR2_aarch64

I've changed this to keep the alphabetic ordering, and applied your
patch to our next branch.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2016-02-21 14:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 19:39 [Buildroot] [PATCH v3] Update libaio to 0.3.110 Alistair Francis
2016-02-20 22:49 ` Arnout Vandecappelle
2016-02-22 17:51   ` Alistair Francis
2016-02-21 14:37 ` Thomas Petazzoni [this message]
2016-02-22 17:52   ` Alistair Francis
2016-04-02 15:53 ` Romain Naour
2016-04-05  0:41   ` Alistair Francis
2016-04-05  0:46     ` Alistair Francis
2016-04-14 21:45       ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160221153709.1bfa1230@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox