From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] gr-osmosdr: new package
Date: Sun, 21 Feb 2016 22:54:04 +0100 [thread overview]
Message-ID: <20160221225404.3760c728@free-electrons.com> (raw)
In-Reply-To: <1454434662-4679-1-git-send-email-gwenj@trabucayre.com>
Dear Gwenhael Goavec-Merou,
On Tue, 2 Feb 2016 18:37:42 +0100, Gwenhael Goavec-Merou wrote:
> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
>
> Add support for gr-osmosdr - a GNU Radio block for interfacing with various
> radio hardware.
>
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> ---
> Changes v1 -> v2:
> - use github instead of tarball (issue with hash changed for same archive
> content);
> - use 'select' gnuradio instead of 'depends on' gnuradio;
> - due to previous point add gnuradio list of dependencies;
> - gr-osmosdr need gnuradio-block -> add select.
> ---
> package/Config.in | 1 +
> package/gr-osmosdr/Config.in | 56 ++++++++++++++++++++++++++++++++++++++
> package/gr-osmosdr/gr-osmosdr.hash | 2 ++
> package/gr-osmosdr/gr-osmosdr.mk | 55 +++++++++++++++++++++++++++++++++++++
> 4 files changed, 114 insertions(+)
> create mode 100644 package/gr-osmosdr/Config.in
> create mode 100644 package/gr-osmosdr/gr-osmosdr.hash
> create mode 100644 package/gr-osmosdr/gr-osmosdr.mk
I've applied to next, after doing a number of changes:
[Thomas:
- instead of selecting BR2_PACKAGE_GNURADIO, use "depends
on". Indeed, it is fairly obvious for a user that some GNURadio
extensions require GNURadio to be built. And it avoids the need to
replicate all the complex dependencies of GNURadio.
- remove comment that the Python support needs Python. It's fairly
obvious, no?
- remove comment about the thread dependency of
BR2_PACKAGE_GR_OSMOSDR_RTLSDR, since anyway GNURadio already need
threads. Yes, we sometimes still add such dependencies, but in the
case of GNURadio, it's highly unlikely that GNURadio will ever
loose the thread dependency.
- use "NO" instead of "no" as the value for
GR_OSMOSDR_SUPPORTS_IN_SOURCE_BUILD since we always use upper-case
letters for the value of such booleans.]
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-02-21 21:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 17:37 [Buildroot] [PATCH v2] gr-osmosdr: new package Gwenhael Goavec-Merou
2016-02-21 21:54 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160221225404.3760c728@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox