From: John Keeping <john@keeping.me.uk>
To: buildroot@busybox.net
Subject: [Buildroot] Analysis of build results for 2016-02-21
Date: Tue, 23 Feb 2016 11:03:40 +0000 [thread overview]
Message-ID: <20160223110340.GK1766@serenity.lan> (raw)
In-Reply-To: <CANCHnQpG80FamNFj6R_8KTB1a--6LjPugDrBCf4cSojGt5XTOg@mail.gmail.com>
On Tue, Feb 23, 2016 at 11:40:52AM +0100, Jeroen Roovers wrote:
> https://gitweb.gentoo.org/repo/gentoo.git/tree/net-wireless/bluez/files/bluez-5.37-endian.patch
That patch looks wrong: you can't just pull a2dp_aptx_t out of the
little/big endian ifdefs since the order of the bit fields matters
(a2dp_ldac_t could be pulled out but I think it's more consistent to
duplicate the definition as the unknown fields may need to be different
on big/little endian systems).
> On 23 February 2016 at 11:12, John Keeping <john@keeping.me.uk> wrote:
> > On Mon, Feb 22, 2016 at 03:05:39PM +0100, Thomas Petazzoni wrote:
> >> On Mon, 22 Feb 2016 08:30:22 +0100 (CET), Thomas Petazzoni wrote:
> >>
> >> > mips | bluez5_utils-5.37 | NOK | http://autobuild.buildroot.net/results/2bf4e5ea9b67b80ba38bfeaf71b747a92be09011/
> >>
> >> tools/avinfo.c:193:24: error: unknown type name 'a2dp_ldac_t'
> >> static void print_ldac(a2dp_ldac_t *ldac)
> >>
> >> It's not MIPS specific, since the same build issue occurred on other
> >> architectures.
> >>
> >> Could someone have a look ?
> >
> > I think the problem affects all big endian systems and the necessary
> > patch to bluez5 is below, but I don't have a suitable toolchain or
> > system to test it.
> >
> > If someone is able to test the patch I will submit it upstream and roll
> > a proper patch for Buildroot.
> >
> > -- >8 --
> > diff --git a/profiles/audio/a2dp-codecs.h b/profiles/audio/a2dp-codecs.h
> > index e9da0bf..4fb5c0c 100644
> > --- a/profiles/audio/a2dp-codecs.h
> > +++ b/profiles/audio/a2dp-codecs.h
> > @@ -234,6 +234,11 @@ typedef struct {
> > uint8_t channel_mode:4;
> > } __attribute__ ((packed)) a2dp_aptx_t;
> >
> > +typedef struct {
> > + a2dp_vendor_codec_t info;
> > + uint8_t unknown[2];
> > +} __attribute__ ((packed)) a2dp_ldac_t;
> > +
> > #else
> > #error "Unknown byte order"
> > #endif
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2016-02-23 11:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 7:30 [Buildroot] [autobuild.buildroot.net] Build results for 2016-02-21 Thomas Petazzoni
2016-02-22 14:05 ` [Buildroot] Analysis of build " Thomas Petazzoni
2016-02-23 10:12 ` John Keeping
2016-02-23 10:40 ` Jeroen Roovers
2016-02-23 11:03 ` John Keeping [this message]
2016-02-23 12:30 ` Thomas Petazzoni
2016-02-24 11:08 ` Eric Limpens
2016-02-24 20:45 ` Arnout Vandecappelle
2016-02-24 20:59 ` Eric Limpens
2016-02-24 21:42 ` Waldemar Brodkorb
2016-02-24 22:09 ` Arnout Vandecappelle
2016-02-27 15:19 ` Romain Naour
2016-02-27 22:05 ` Bernd Kuhls
2016-03-01 9:38 ` Thomas Petazzoni
2016-02-28 0:17 ` Bernd Kuhls
2016-03-01 9:39 ` Thomas Petazzoni
2016-03-03 13:56 ` Gustavo Zacarias
-- strict thread matches above, loose matches on Subject: below --
2016-02-22 19:05 Olivier Schonken
2016-02-22 21:55 ` Romain Naour
2016-02-22 22:21 ` Thomas Petazzoni
2016-02-23 7:34 ` Olivier Schonken
2016-02-23 8:11 ` Thomas Petazzoni
2016-02-23 11:13 ` Olivier Schonken
2016-02-24 21:30 ` Waldemar Brodkorb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223110340.GK1766@serenity.lan \
--to=john@keeping.me.uk \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox