Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] configs: atmel: ensure EABIhf is selected for sama5d*
Date: Tue, 23 Feb 2016 22:18:29 +0100	[thread overview]
Message-ID: <20160223211829.GA10681@piout.net> (raw)
In-Reply-To: <87fuwj6tot.fsf@dell.be.48ers.dk>

On 23/02/2016 at 21:46:42 +0100, Peter Korsgaard wrote :
> >>>>> "Alexandre" == Alexandre Belloni <alexandre.belloni@free-electrons.com> writes:
> 
>  > The recent changes in Config.in.arm regarding the VFP selection broke the
>  > atmel_sama5d* defconfigs. Ensure EABIhf is selected as all the sama5 have a
>  > vfp.
> 
> They are not really broken in the sense that they don't build or boot,
> they are just less optimal, right?
> 

Indeed.

>  > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>  > ---
>  >  configs/atmel_sama5d3_xplained_defconfig | 3 +--
>  >  configs/atmel_sama5d3xek_defconfig       | 3 +--
>  >  configs/atmel_sama5d4_xplained_defconfig | 3 +--
> 
> We also have a atmel_sama5d3_xplained_mmc_defconfig that you
> forgot. Committed with that fixed, thanks.
> 

I changed it and I forgot to amend my commit, thanks for fixing that.

> It seems like we need to fixup the other defconfigs using EABIHF as well
> :/ In hindsight, maybe BR2_ARM_ENABLE_VFP should have defaulted to 'y'
> instead.
> 

Off list, I was suggesting to Thomas add BR2_ARM_ENABLE_VFP = y to all
defconfigs with a BR2_ARM_FPU_VFP* but it only catches four more
defconfigs. However, there are a lot more, like beaglebone, the
allwiner based boards, most of the freescale ones, etc...

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-02-23 21:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23 16:19 [Buildroot] [PATCH] configs: atmel: ensure EABIhf is selected for sama5d* Alexandre Belloni
2016-02-23 20:46 ` Peter Korsgaard
2016-02-23 21:18   ` Alexandre Belloni [this message]
2016-02-23 21:25     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160223211829.GA10681@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox