From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] package/python-web2py: cleaning for space saving
Date: Tue, 23 Feb 2016 23:43:14 +0100 [thread overview]
Message-ID: <20160223234314.7d391cbc@free-electrons.com> (raw)
In-Reply-To: <1438070683-2109-1-git-send-email-angelo.compagnucci@gmail.com>
Angelo,
On Tue, 28 Jul 2015 10:04:43 +0200, Angelo Compagnucci wrote:
> This patch removes from web2py folder welcome, examples application
> and a bunch of other files uneeded in production,
> furthermore, it removes the admin interface if unneeded.
>
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
I saw this old patch having Reviewed-by from Arnout and Yann and was
therefore tempted to apply it. However, I believe Arnout and Yann made
some very valuable comments before giving their Reviewed-by, and I
would prefer to see those comments be implemented rather than applying
the patch as-is.
To sum-up, the comments are:
* Split in three patches: 1/ clean-up the installation, 2/ add option
to remove the admin interface, 3/ move the admin password generation
from install time to build time. This will also mean you'll have
more detailed commit log, which will also fulfill a comment made by
Yann.
* Use rsync with exclude to copy only the useful files
Could you rework this patch to take into account those comments?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-02-23 22:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 8:04 [Buildroot] [PATCH v4] package/python-web2py: cleaning for space saving Angelo Compagnucci
2015-12-29 20:49 ` Angelo Compagnucci
2015-12-30 15:03 ` Arnout Vandecappelle
2016-01-10 13:26 ` Yann E. MORIN
2016-02-23 22:43 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223234314.7d391cbc@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox