From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 25 Feb 2016 10:46:43 +0100 Subject: [Buildroot] [PATCH 1/1] Added OK/FAIL output to SNMP init script. In-Reply-To: <1456335081-4834-1-git-send-email-universeII@gmx.de> References: <1456335081-4834-1-git-send-email-universeII@gmx.de> Message-ID: <20160225104643.0921463c@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Andreas Ehmanns, On Wed, 24 Feb 2016 18:31:21 +0100, Andreas Ehmanns wrote: > Signed-off-by: Andreas Ehmanns > --- > package/netsnmp/S59snmpd | 98 +++++++++++++++++++++++++++--------------------- > 1 file changed, 56 insertions(+), 42 deletions(-) While your patch looks OK, it is doing *much* more than "adding OK/FAIL" as your commit title indicates. Ideally, you should separate your changes into multiple patches to make it easier to review the changes (like one patch to change to use functions, one patch to add OK/FAIL, one patch to remove set -e, etc.). Or at least, write a commit log that details all the changes that are being done. Thanks a lot! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com