From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [Buildroot PATCH Selinux v10 04/11] linux-pam: selinux host dependencies
Date: Fri, 26 Feb 2016 09:17:08 +0100 [thread overview]
Message-ID: <20160226091708.04d0828a@free-electrons.com> (raw)
In-Reply-To: <CAMshMJa8n2bFW1Jj3ssMBDgkM-Qkq=qe35x__X=f8HD0zCGSnQ@mail.gmail.com>
Niranjan,
On Fri, 26 Feb 2016 12:28:39 +0530, Niranjan Reddy wrote:
> > > + if [ -d $(TARGET_DIR)/etc/pam.d.orig ]; then \
> > > + cp -a $(TARGET_DIR)/etc/pam.d/*
> > $(TARGET_DIR)/etc/pam.d.orig/; \
> > > + rm -rf $(TARGET_DIR)/etc/pam.d/; \
> > > + mv $(TARGET_DIR)/etc/pam.d.orig/ $(TARGET_DIR)/etc/pam.d/;
> > \
> > > + fi;
> >
> > ; not needed
> >
>
> Are you sure you want me to remove these ? If I remove " ; \" it gives
> me compilation error. when I see
> build-root manual in section 17.15.2 , if condition statements are ended
> with semicolon. Please let me know.
I'm not asking you to remove all ; \, but only to remove the ones that
separate independent commands, since they are useless. I.e you are
currently doing:
1 if [ ... ] ; then \
2 cp -a ..... ; \
3 fi ; \
4 cd $(TARGET_DIR) .... ; \
5 if [ ... ] ; then \
6 cp -a .... ; \
7 fi ; \
8 $(INSTALL) -D ...
The \ or ; \ is needed on lines 1, 2, 4 and 5. But not on lines 3 and 7.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-26 8:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 6:18 [Buildroot] [Buildroot PATCH Selinux v10 01/11] dbus: selinux file context support Niranjan Reddy
2016-02-16 6:18 ` [Buildroot] [Buildroot PATCH Selinux v10 02/11] linux-pam: selinux audit dependencies Niranjan Reddy
2016-02-23 21:29 ` Thomas Petazzoni
2016-02-16 6:18 ` [Buildroot] [Buildroot PATCH Selinux v10 03/11] linux-pam: selinux system auth Niranjan Reddy
2016-02-23 21:31 ` Thomas Petazzoni
2016-02-16 6:18 ` [Buildroot] [Buildroot PATCH Selinux v10 04/11] linux-pam: selinux host dependencies Niranjan Reddy
2016-02-23 21:36 ` Thomas Petazzoni
2016-02-26 6:58 ` Niranjan Reddy
2016-02-26 8:17 ` Thomas Petazzoni [this message]
2016-02-16 6:18 ` [Buildroot] [Buildroot PATCH Selinux v10 05/11] busybox: applets as individual binaries Niranjan Reddy
2016-02-23 21:47 ` Thomas Petazzoni
2016-02-16 6:18 ` [Buildroot] [Buildroot PATCH Selinux v10 06/11] policycoreutils: new package Niranjan Reddy
2016-02-23 22:03 ` Thomas Petazzoni
2016-02-16 6:18 ` [Buildroot] [Buildroot PATCH Selinux v10 07/11] qemu x86 selinux: base br defconfig Niranjan Reddy
2016-02-23 21:55 ` Thomas Petazzoni
2016-03-01 6:43 ` Niranjan Reddy
2016-02-16 6:18 ` [Buildroot] [Buildroot PATCH Selinux v10 08/11] refpolicy: new package Niranjan Reddy
2016-02-23 22:25 ` Thomas Petazzoni
2016-02-16 6:18 ` [Buildroot] [Buildroot PATCH Selinux v10 09/11] python-pyparsing: Add host build option Niranjan Reddy
2016-02-23 21:50 ` Thomas Petazzoni
2016-02-16 6:18 ` [Buildroot] [Buildroot PATCH Selinux v10 10/11] util-linux: selinux, audit, and pam support Niranjan Reddy
2016-02-23 22:07 ` Thomas Petazzoni
2016-02-16 6:18 ` [Buildroot] [Buildroot PATCH Selinux v10 11/11] qemu x86 selinux: added common selinux support files Niranjan Reddy
2016-02-23 21:25 ` [Buildroot] [Buildroot PATCH Selinux v10 01/11] dbus: selinux file context support Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160226091708.04d0828a@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox