Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] screen: bump to version 4.3.1
Date: Sun, 28 Feb 2016 22:24:59 +0100	[thread overview]
Message-ID: <20160228222459.5be7efb5@free-electrons.com> (raw)
In-Reply-To: <1456617671-27271-1-git-send-email-ricardo.martincoski@gmail.com>

Ricardo,

On Sat, 27 Feb 2016 21:01:11 -0300, Ricardo Martincoski wrote:
> Patch files 0001 to 0005 were rebased.
> 
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Applied to next, thanks. One comment though.

> "src/" must be removed from the patches because _STRIP_COMPONENTS is not
> set, so it defaults to 1
> If I set SCREEN_STRIP_COMPONENTS=0, I would need to generate patches
> 0006-0010 again, so I kept the default 1.

The problem has nothing to do with <pkg>_STRIP_COMPONENTS. Even with
_STRIP_COMPONENTS = 0, patches with src/ wouldn't apply.

The problem is that the layout of the screen Git repository does not
match the layout of their tarball. Their Git repository has pretty much
nothing but a src/ sub-directory. While their tarball contain under a
screen-<version>/ directory directly the contents of the Git repository
src/ directory.

If you were to use <pkg>_STRIP_COMPONENTS = 0, you would have the
screen source code in:

  output/build/screen-<version>/screen-<version>/

and still no src/ directory.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2016-02-28 21:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-28  0:01 [Buildroot] [PATCH] screen: bump to version 4.3.1 Ricardo Martincoski
2016-02-28 21:24 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160228222459.5be7efb5@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox