Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit branch/next] package/lz4: bump version to r131
Date: Mon, 29 Feb 2016 23:14:53 +0100	[thread overview]
Message-ID: <20160229231453.6930fcb1@free-electrons.com> (raw)
In-Reply-To: <87oaaznps3.fsf@dell.be.48ers.dk>

Dear Peter Korsgaard,

On Mon, 29 Feb 2016 22:57:16 +0100, Peter Korsgaard wrote:

>  >  define HOST_LZ4_INSTALL_CMDS
>  > -	$(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D) install DESTDIR=$(HOST_DIR)
>  > +	$(MAKE) $(HOST_CONFIGURE_OPTS) DESTDIR=$(HOST_DIR) \
>  > +		PREFIX=/usr install -C $(@D)
> 
> Hmm, why are we passing DESTDIR + PREFIX=/usr, instead of
> PREFIX=$(HOST_DIR)/usr for host installation?

Good point. I guess I got confused by the fact that we were already
passing DESTDIR=$(HOST_DIR). We should indeed be passing
PREFIX=$(HOST_DIR)/usr.

Let me fire up a test build and see if that works as expected.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2016-02-29 22:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29 21:38 [Buildroot] [git commit branch/next] package/lz4: bump version to r131 Thomas Petazzoni
2016-02-29 21:57 ` Peter Korsgaard
2016-02-29 22:14   ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160229231453.6930fcb1@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox