From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC PATCH 2/3] Add package cbootimage
Date: Wed, 2 Mar 2016 21:38:12 +0100 [thread overview]
Message-ID: <20160302213812.36ab0fe9@free-electrons.com> (raw)
In-Reply-To: <1455203110-16759-3-git-send-email-julian@jusst.de>
Dear Julian Scheel,
On Thu, 11 Feb 2016 10:05:09 -0500, Julian Scheel wrote:
> diff --git a/package/cbootimage/Config.in.host b/package/cbootimage/Config.in.host
> new file mode 100644
> index 0000000..4cdde38
> --- /dev/null
> +++ b/package/cbootimage/Config.in.host
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_HOST_CBOOTIMAGE
> + bool "host cbootimage"
Same thing: please add a "depends on BR2_arm || BR2_armeb" here.
> diff --git a/package/cbootimage/cbootimage.mk b/package/cbootimage/cbootimage.mk
> new file mode 100644
> index 0000000..3efef36
> --- /dev/null
> +++ b/package/cbootimage/cbootimage.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# cbootimage
> +#
> +################################################################################
> +
> +# Stick with git snapshot as latest release misses bugfixes for signing
> +CBOOTIMAGE_VERSION = e7d840c
> +CBOOTIMAGE_SITE = https://github.com/NVIDIA/cbootimage.git
> +CBOOTIMAGE_SITE_METHOD = git
Please use the github helper function.
> +CBOOTIMAGE_LICENSE = GPLv2
You can add CBOOTIMAGE_LICENSE_FILES = COPYING
Other than that, looks good to me.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-02 20:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 15:05 [Buildroot] [RFC PATCH 0/3] Add flashing tools for tegra processors Julian Scheel
2016-02-11 15:05 ` [Buildroot] [RFC PATCH 1/3] Add package tegrarcm Julian Scheel
2016-03-02 20:35 ` Thomas Petazzoni
2016-02-11 15:05 ` [Buildroot] [RFC PATCH 2/3] Add package cbootimage Julian Scheel
2016-03-02 20:38 ` Thomas Petazzoni [this message]
2016-02-11 15:05 ` [Buildroot] [RFC PATCH 3/3] Add package cbootimage-configs Julian Scheel
2016-03-15 10:42 ` Yann E. MORIN
2016-03-17 8:28 ` Julian Scheel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302213812.36ab0fe9@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox