From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/ffmpeg: improve inline asm handling for libpostproc
Date: Sun, 6 Mar 2016 15:07:01 +0100 [thread overview]
Message-ID: <20160306150701.6caec643@free-electrons.com> (raw)
In-Reply-To: <1457262024-2160-1-git-send-email-bernd.kuhls@t-online.de>
Bernd,
On Sun, 6 Mar 2016 12:00:24 +0100, Bernd Kuhls wrote:
> ifeq ($(BR2_PACKAGE_FFMPEG_POSTPROC),y)
> FFMPEG_CONF_OPTS += --enable-postproc
> +# disable inline-asm on non-mmx Intel CPUs
> +ifeq ($(BR2_i386)$(BR2_X86_CPU_HAS_MMX),y)
> +FFMPEG_CONF_OPTS += --disable-inline-asm
On x86-64, BR2_i386 is false, but BR2_X86_CPU_HAS_MMX=y, so you will
disable inline-asm. Is this what you want?
Why isn't the condition simply:
ifeq ($(BR2_X86_CPU_HAS_MMX),)
FFMPEG_CONF_OPTS += --disable-inline-asm
endif
Which actually matches your comment: when you have a non-MMX capable
Intel CPU -> disable inline assembly.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-03-06 14:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 11:00 [Buildroot] [PATCH 1/1] package/ffmpeg: improve inline asm handling for libpostproc Bernd Kuhls
2016-03-06 14:07 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160306150701.6caec643@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox