From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/nodejs: force the use of python2
Date: Sun, 6 Mar 2016 15:43:41 +0100 [thread overview]
Message-ID: <20160306154341.30fc8162@free-electrons.com> (raw)
In-Reply-To: <1457044168-31810-1-git-send-email-martin@barkynet.com>
Dear Martin Bark,
On Thu, 3 Mar 2016 22:29:27 +0000, Martin Bark wrote:
> Remove the patches to use a python variable and instead force python2
> into the PATH.
>
> Upstream the python variable was recently removed
> (see https://github.com/nodejs/node/commit/c3e50ca) and due to dependencies
> directly calling python there is a reluctance to change this. Instead it
> is recommended to add python2 into PATH as the nodejs build machines do
> (see https://github.com/nodejs/node/issues/418 and
> https://github.com/nodejs/node/issues/2735).
>
> Signed-off-by: Martin Bark <martin@barkynet.com>
> ---
> ...ch => 0003-fix-musl-USE-MISC-build-issue.patch} | 0
> .../nodejs/0.10.42/0003-use-python-variable.patch | 43 --------
> .../0004-Fix-support-for-uClibc-ng.patch} | 0
> ...d.patch => 0003-Fix-va_list-not-declared.patch} | 0
> ...hon-variable-instead-of-hardcoding-Python.patch | 112 ---------------------
> .../0004-Fix-support-for-uClibc-ng.patch} | 0
> package/nodejs/nodejs.mk | 18 +++-
> 7 files changed, 16 insertions(+), 157 deletions(-)
> rename package/nodejs/0.10.42/{0004-fix-musl-USE-MISC-build-issue.patch => 0003-fix-musl-USE-MISC-build-issue.patch} (100%)
> delete mode 100644 package/nodejs/0.10.42/0003-use-python-variable.patch
> rename package/nodejs/{5.6.0/0005-Fix-support-for-uClibc-ng.patch => 0.10.42/0004-Fix-support-for-uClibc-ng.patch} (100%)
> rename package/nodejs/5.6.0/{0004-Fix-va_list-not-declared.patch => 0003-Fix-va_list-not-declared.patch} (100%)
> delete mode 100644 package/nodejs/5.6.0/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch
> rename package/nodejs/{0.10.42/0005-Fix-support-for-uClibc-ng.patch => 5.6.0/0004-Fix-support-for-uClibc-ng.patch} (100%)
Both patches applied. It is a little bit sad that upstream removed the
variable to define the path to the Python interpreter. But oh well,
this allows us to remove quite a few patches.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-06 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 22:29 [Buildroot] [PATCH 1/2] package/nodejs: force the use of python2 Martin Bark
2016-03-03 22:29 ` [Buildroot] [PATCH 2/2] package/nodejs: bump version to 5.7.1 Martin Bark
2016-03-06 14:43 ` Thomas Petazzoni [this message]
2016-03-07 9:51 ` [Buildroot] [PATCH 1/2] package/nodejs: force the use of python2 Martin Bark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160306154341.30fc8162@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox