From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] luaposix: bump to version 33.4.0
Date: Sun, 6 Mar 2016 15:48:05 +0100 [thread overview]
Message-ID: <20160306154805.21d478f2@free-electrons.com> (raw)
In-Reply-To: <1457039566-3326-3-git-send-email-francois.perrad@gadz.org>
Dear Francois Perrad,
On Thu, 3 Mar 2016 22:12:46 +0100, Francois Perrad wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> ...round-glibc-_POSIX_PRIORITY_SCHEDULING-bu.patch | 59 ----------------------
> package/luaposix/Config.in | 12 ++---
> package/luaposix/luaposix.mk | 6 +--
> 3 files changed, 7 insertions(+), 70 deletions(-)
> delete mode 100644 package/luaposix/0001-sched-workaround-glibc-_POSIX_PRIORITY_SCHEDULING-bu.patch
I've applied, but I almost rejected the patch, to be honest. Your patch
does a *lot* more than bumping the version, but your commit log is
empty. Your commit log should have explained why the patch is removed,
and why the ncurses dependency is removed.
I had to go look up for this myself, which is a bit annoying since you
already did this work.
Fran?ois, this is the 100th time I'm asking you about this: please
*ALWAYS* write a commit log in your patches. *ALWAYS*.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-06 14:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 21:12 [Buildroot] [PATCH 1/3] copas: bump to version 2.0.1 Francois Perrad
2016-03-03 21:12 ` [Buildroot] [PATCH 2/3] lua-messagepack: bump to version 0.3.4 Francois Perrad
2016-03-06 14:46 ` Thomas Petazzoni
2016-03-03 21:12 ` [Buildroot] [PATCH 3/3] luaposix: bump to version 33.4.0 Francois Perrad
2016-03-06 14:48 ` Thomas Petazzoni [this message]
2016-03-06 14:46 ` [Buildroot] [PATCH 1/3] copas: bump to version 2.0.1 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160306154805.21d478f2@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox