From: Pieter Smith <pieter@boesman.nl>
To: buildroot@busybox.net
Subject: [Buildroot] [v3, 1/4] barebox: prepare for secondary config build
Date: Mon, 7 Mar 2016 19:31:45 +0100 [thread overview]
Message-ID: <20160307183145.GA8550@smipidev> (raw)
In-Reply-To: <56DC9E47.2090207@mind.be>
On Sun, Mar 06, 2016 at 10:16:55PM +0100, Arnout Vandecappelle wrote:
> On 03/05/16 14:16, Pieter Smith wrote:
[snip]
> > I am having some trouble with this. I am not able to handle ifdef-space
> > diversity in this way. Ifdef-space diversity is used to determine how barebox
> > should be configured, whether / how the barebox environment should be built,
> > and to print user-friendly config errors. The ifdef logic is not all trivial
> > (almost half of the makefile logic), so I would like to avoid duplicating it
> > between barebox and barebox-2. The only way I know of to avoid this duplication
> > is by extracting the logic info a definition and using $(eval), which is
> > exactly what you want to avoid.
>
> Ah yes, I didn't realize that. Indeed, for those things there is no way to
> handle them with $(PKG).
>
> Actually I would like those things to move to kconfig-package, but that would
> be dragging things a bit too far for this series.
>
> So yes, your idea of $(call barebox-package) looks good. One small remark that
> you can already fix before submitting: in the patch that adds the
> barebox-package function, say explicitly in the commit message if anything has
> changed except for $ -> $$ and BAREBOX -> $(1). That'll make review easier.
Thanks for having a look. I will break the series up into smaller pieces to
ease review:
1 - 2 as before.
3. Break out barebox-package (Explain the $ -> $$ subst).
4. Make the variable name-space configurable (Explain BAREBOX -> $(1) subst).
5. Make the package source name-space configurable (Explain BAREBOX -> $(2)
subst).
6. Introduce boot/barebox-2/barebox-2.mk and Config.in with
$(call barebox-package,BAREBOX_2,BAREBOX)
7. Add a defconfig for the BBB.
[snip]
Thank you for helping to bang this into shape.
- Pieter
next prev parent reply other threads:[~2016-03-07 18:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 22:43 [Buildroot] [v3, 0/4] Supporting building a second Barebox config Pieter Smith
2016-01-20 22:43 ` [Buildroot] [v3, 1/4] barebox: prepare for secondary config build Pieter Smith
2016-02-22 11:03 ` Yegor Yefremov
2016-02-26 23:17 ` Arnout Vandecappelle
2016-02-28 8:12 ` Pieter Smith
2016-02-29 7:47 ` Pieter Smith
2016-03-01 23:08 ` Arnout Vandecappelle
2016-03-02 7:50 ` Pieter Smith
2016-03-02 18:12 ` Arnout Vandecappelle
2016-03-02 21:32 ` Pieter Smith
2016-03-05 13:16 ` Pieter Smith
2016-03-06 21:16 ` Arnout Vandecappelle
2016-03-07 18:31 ` Pieter Smith [this message]
2016-02-29 7:57 ` Pieter Smith
2016-01-20 22:43 ` [Buildroot] [v3, 2/4] barebox: adds option to build secondary config Pieter Smith
2016-02-22 11:03 ` Yegor Yefremov
2016-02-26 23:26 ` Arnout Vandecappelle
2016-02-29 8:01 ` Pieter Smith
2016-01-20 22:43 ` [Buildroot] [v3, 3/4] barebox: user selection of build output images Pieter Smith
2016-02-22 11:03 ` Yegor Yefremov
2016-02-26 23:43 ` Arnout Vandecappelle
2016-02-29 8:38 ` Pieter Smith
2016-03-01 23:14 ` Arnout Vandecappelle
2016-03-02 7:54 ` Pieter Smith
2016-03-02 18:18 ` Arnout Vandecappelle
2016-03-02 21:40 ` Pieter Smith
2016-03-06 23:03 ` Arnout Vandecappelle
2016-01-20 22:43 ` [Buildroot] [v3, 4/4] beaglebone: adds barebox bootloader defconfig Pieter Smith
2016-02-22 11:04 ` Yegor Yefremov
2016-02-26 23:47 ` Arnout Vandecappelle
2016-02-26 23:48 ` Arnout Vandecappelle
2016-02-29 8:44 ` Pieter Smith
2016-03-01 23:15 ` Arnout Vandecappelle
2016-03-02 7:55 ` Pieter Smith
2016-02-16 11:55 ` [Buildroot] [v3, 0/4] Supporting building a second Barebox config Yegor Yefremov
2016-02-16 18:55 ` Pieter Smith
2016-02-16 21:27 ` Yegor Yefremov
2016-02-21 17:25 ` Pieter Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307183145.GA8550@smipidev \
--to=pieter@boesman.nl \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox