From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkgconf: make wrapper relocatable
Date: Wed, 9 Mar 2016 15:50:41 +0100 [thread overview]
Message-ID: <20160309155041.5aac1077@free-electrons.com> (raw)
In-Reply-To: <8760wv2079.fsf@dell.be.48ers.dk>
Dear Peter Korsgaard,
On Wed, 09 Mar 2016 15:30:18 +0100, Peter Korsgaard wrote:
> > WRAPPER_DIR=$(dirname $0)
>
> That relies on argv[0] containing the full path, which it normally will
> do when you run it from the shell, but isn't guaranteed to work. If we
> want to support that then we should use /proc/self/exe
Well, OK.
> > STAGING_DIR=$(readlink -f ${WRAPPER_DIR}/../../../staging/)
>
> This will only work if you keep the entire buildroot output around (or
> rather output/staging) and don't customize the BR2_HOST_DIR.
Indeed, so we need to do like Arnout suggests, hardcoding the tuple
inside the script, so that we really only on the contents of host/, and
not on the staging symlink.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-09 14:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 13:16 [Buildroot] [PATCH] pkgconf: make wrapper relocatable Gustavo Zacarias
2016-03-09 13:46 ` Peter Korsgaard
2016-03-09 13:51 ` Gustavo Zacarias
2016-03-09 14:00 ` Peter Korsgaard
2016-03-09 14:04 ` Gustavo Zacarias
2016-03-09 14:31 ` Peter Korsgaard
2016-03-09 14:37 ` Arnout Vandecappelle
2016-03-09 14:40 ` Gustavo Zacarias
2016-03-09 14:46 ` Peter Korsgaard
2016-03-09 14:52 ` Arnout Vandecappelle
2016-03-09 15:06 ` Peter Korsgaard
2016-03-09 14:03 ` Thomas Petazzoni
2016-03-09 14:28 ` Gustavo Zacarias
2016-03-09 14:40 ` Arnout Vandecappelle
2016-03-09 14:41 ` Gustavo Zacarias
2016-03-09 14:42 ` Arnout Vandecappelle
2016-03-09 14:30 ` Peter Korsgaard
2016-03-09 14:50 ` Thomas Petazzoni [this message]
2016-03-09 14:55 ` Peter Korsgaard
2016-03-09 15:22 ` Samuel Martin
2016-03-09 15:55 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160309155041.5aac1077@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox