Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] openpgm: depends on sync2/sync4
Date: Wed, 16 Mar 2016 16:53:10 +0100	[thread overview]
Message-ID: <20160316165310.1b536bc3@free-electrons.com> (raw)
In-Reply-To: <1458138013-18031-1-git-send-email-gustavo@zacarias.com.ar>

Gustavo,

On Wed, 16 Mar 2016 11:20:13 -0300, Gustavo Zacarias wrote:
> Add dependency on BR2_TOOLCHAIN_HAS_SYNC_2/4 since it uses both
> __sync_fetch_and_add_2() and __sync_fetch_and_add_4() atomic builtins.
> Fixes:
> http://autobuild.buildroot.net/results/8f2/8f2a3571611dc9414c23808e7615f87b677557dd/
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  package/openpgm/Config.in | 4 ++++
>  package/zeromq/Config.in  | 2 ++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/package/openpgm/Config.in b/package/openpgm/Config.in
> index 94816d8..632c289 100644
> --- a/package/openpgm/Config.in
> +++ b/package/openpgm/Config.in
> @@ -1,5 +1,7 @@
>  config BR2_PACKAGE_OPENPGM
>  	bool "openpgm"
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_2
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4
>  	# This toolchain lack required compiler intrinsics
>  	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX

Maybe we can remove this dependency then?

Blackfin provides __sync_*() for 4-bytes, but not for 2 bytes.

And indeed, the original commit that added this dependency points to
http://autobuild.buildroot.org/results/3bd/3bda860a269dd9a4e38533cc9350892c68102618/build-end.log,
which shows undefined reference for the two bytes variants.

Could you submit an updated patch that removes the Blackfin dependency?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-03-16 15:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 14:20 [Buildroot] [PATCH] openpgm: depends on sync2/sync4 Gustavo Zacarias
2016-03-16 15:53 ` Thomas Petazzoni [this message]
2016-03-16 19:09   ` Gustavo Zacarias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160316165310.1b536bc3@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox