From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sun, 20 Mar 2016 14:29:32 +0100 Subject: [Buildroot] [PATCH 02/16 v5] core/pkg-utils: add macro to hardlink-or-copy In-Reply-To: <20160319231143.GH3426@free.fr> References: <909a98f9ebb10986a85570d767ab030597a73ef5.1457718289.git.yann.morin.1998@free.fr> <20160319152307.765e1bad@free-electrons.com> <20160319231143.GH3426@free.fr> Message-ID: <20160320142932.71a3493a@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Sun, 20 Mar 2016 00:11:43 +0100, Yann E. MORIN wrote: > > define hardlink-or-copy > > $(call hardlink-or-copy-inner,$(1),$(if $(3),$(2)/$(3),$(2)/$(basename $(1)))) > > endef > > Well, that does not work. That's basically what I did in the previous > iteration, but in some cases, $(3) could be a shell expansion and it is > not empty at the time the macro is called, but ends up being empty after > the shell expansion. See the discussion we had with Luca about this: > http://lists.busybox.net/pipermail/buildroot/2016-February/152634.html Hum, I see. We wouldn't have this problem if we were to know, at the infra level, the entire list of patches that get applied. But indeed, if we need to use the file generated by apply-patches, using a pure make function doesn't seem to work. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com