Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] linux: Build and install kernel selftests
Date: Sun, 20 Mar 2016 22:09:03 +0100	[thread overview]
Message-ID: <20160320220903.60ba5372@free-electrons.com> (raw)
In-Reply-To: <1458098793-28532-1-git-send-email-cyrilbur@gmail.com>

Hello,

On Wed, 16 Mar 2016 14:26:33 +1100, Cyril Bur wrote:
> +config BR2_LINUX_KERNEL_TOOL_SELFTESTS
> +	bool"selftests"
> +	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # bash
> +	depends on BR2_USE_MMU  # bash
> +	select BR2_PACKAGE_BASH
> +	select BR2_PACKAGE_POPT
> +	select BR2_PACKAGE_LIBCAP_NG
> +	help
> +	  Build and install (to /usr/lib/kselftests) kernel selftests.
> +
> +	  Use of this option implies you know the process using and compiling

There was a typo here, a missing word between "process" and "using".

> +	  the kernel selftests. The Makefile to build and install these is very
> +	  noisy and may appear to cause your build to fail for strange reasons.
> +
> +	  This is very much a use at your risk option and may not work for
> +	  every setup or every architecture.

Those lines were slightly too long.

> +
> +comment "selftests needs BR2_PACKAGE_BUSYBOX_SHOW_OTHERS"
> +	depends on !BR2_PACKAGE_BUSYBOX_SHOW_OTHERS

You should have replicated the BR2_USE_MMU dependency here.

> +SELFTESTS_DEPENDENCIES = bash libcap-ng popt

bash is not needed at build time, it's only a runtime dependency, so
I've removed it from this variable (but kept it as a select in
Config.in, and added a comment that indicates it's a runtime
dependency).

It's worth noting that with uClibc, a number of tests fail to build,
but I guess that's expected, and it doesn't abort the build.

I've applied with the fixes I mentioned above.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2016-03-20 21:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16  3:26 [Buildroot] [PATCH v3] linux: Build and install kernel selftests Cyril Bur
2016-03-20 21:09 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160320220903.60ba5372@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox