Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_LIBATOMIC
Date: Sun, 20 Mar 2016 23:41:18 +0100	[thread overview]
Message-ID: <20160320234118.106809e6@free-electrons.com> (raw)
In-Reply-To: <1457297237-4064-1-git-send-email-thomas.petazzoni@free-electrons.com>

Hello,

On Sun,  6 Mar 2016 21:47:16 +0100, Thomas Petazzoni wrote:
> Until now, we were assuming that whenever you have gcc 4.8, libatomic
> is available. It turns out that this is not correct, since libatomic
> will not be available if thread support is disabled in the toolchain.
> 
> Therefore, __atomic_*() intrinsics may not be available even if the
> toolchain uses gcc 4.8.
> 
> To solve this problem, we introduce a BR2_TOOLCHAIN_HAS_LIBATOMIC
> boolean, which indicates whether the toolchain has libatomic. It is
> the case when you are using gcc >= 4.8 *and* thread support is
> enabled. We then use this new BR2_TOOLCHAIN_HAS_LIBATOMIC to define
> BR2_TOOLCHAIN_HAS_ATOMIC.
> 
> As explained in the comment, on certain architectures, libatomic is
> technically not needed to provide the __atomic_*() intrinsics since
> they might be all built-in. However, since libatomic is only absent in
> non-thread capable toolchains, it is not worth making things more
> complex for such seldomly used configuration.
> 
> Note that we are introducing the intermediate
> BR2_TOOLCHAIN_HAS_LIBATOMIC option because it will be useful on its
> own for certain packages.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  toolchain/toolchain-common.in | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)

I've applied, after modifying the Config.in comment as suggested by
Yann. I've also applied PATCH 2/2, which had Yann's Reviewed-by.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2016-03-20 22:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-06 20:47 [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_LIBATOMIC Thomas Petazzoni
2016-03-06 20:47 ` [Buildroot] [PATCH 2/2] cairo, icu, webkitgtk24: use BR2_TOOLCHAIN_HAS_LIBATOMIC Thomas Petazzoni
2016-03-07 20:43   ` Yann E. MORIN
2016-03-07 20:41 ` [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_LIBATOMIC Yann E. MORIN
2016-03-20 22:41 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160320234118.106809e6@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox