From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] linknx: select libcurl to fix autoreconf
Date: Tue, 29 Mar 2016 20:33:14 +0300 [thread overview]
Message-ID: <20160329173313.GR2637@tarshish> (raw)
In-Reply-To: <20160329150549.3e9fdb7c@free-electrons.com>
Hi Thomas,
On Tue, Mar 29, 2016 at 03:05:49PM +0200, Thomas Petazzoni wrote:
> On Wed, 16 Mar 2016 21:38:28 +0200, Baruch Siach wrote:
> > linknx configure.ac uses the LIBCURL_CHECK_CONFIG macro that is only defined
> > in libcurl.m4 that is part of libcurl. Select libcurl for now to fix
> > autoreconf.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/96e/96e9ae0df7ebb7ad3d748a6b518cc59570e0b995/
> > http://autobuild.buildroot.net/results/179/17971c9f8925ff8623a7d97aac8eda0c287a76c9/
> > http://autobuild.buildroot.net/results/2a8/2a8af93d6439b313b048ccac7b6cfecbb6baff55/
> >
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>
> It's not super nice to have to add this mandatory dependency for
> autoreconf, but we indeed don't really have the choice. We should
> remember to revert this patch once the linknx patch gets merged
> upstream, and we bump the version. However, it seems like linknx is not
> super active upstream, so in fact things might just stay forever as they
> are today. Oh well.
A possible alternative is to have a local copy of libcurl.m4 for linknx,
either in a patch or standalone. Would you prefer that?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2016-03-29 17:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 19:38 [Buildroot] [PATCH] linknx: select libcurl to fix autoreconf Baruch Siach
2016-03-29 13:05 ` Thomas Petazzoni
2016-03-29 17:33 ` Baruch Siach [this message]
2016-03-29 17:58 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329173313.GR2637@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox