From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] radlib: new package
Date: Tue, 29 Mar 2016 23:51:53 +0200 [thread overview]
Message-ID: <20160329235153.21664d17@free-electrons.com> (raw)
In-Reply-To: <1459287337.10145.3.camel@intel.com>
Hello,
On Tue, 29 Mar 2016 21:35:37 +0000, Kinsella, Ray wrote:
> > Please use git send-email to send your patches. Due to not using git
> > send-email, your e-mail is badly line-wrapped and cannot be applied,
> > and even less reviewed nicely.
>
> ok - I will figure out the smtp setup.
Plenty of @intel.com people contribute to the kernel, and use git
send-email. So I'm sure you can find the appropriate SMTP setup :)
> > This should go below the "---" sign.
>
> ok the 'Delta's from v1:-' should be moved after the Signed-off-by
> line?
After the --- separator that follows the SoB line.
> > So you're doing three different things. Which calls for three
> > different
> > patches.
>
> Hopefully this won't require me to re-org the patch.
Well, you'll have to split your "big" patch into three smaller patches.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-03-29 21:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 19:40 [Buildroot] [PATCH v2] radlib: new package Kinsella, Ray
2016-03-29 18:07 ` Thomas Petazzoni
2016-03-29 21:35 ` Kinsella, Ray
2016-03-29 21:51 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329235153.21664d17@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox